Will this be ported over to drupal 6 ?

CommentFileSizeAuthor
#6 comment_alter_taxonomy_d5-d6_port.patch13.36 KBultimateboy
#3 admin_message_d5-d6_port.patch16.13 KBultimateboy
#3 admin_message.zip7.06 KBultimateboy

Comments

anders.fajerson’s picture

anders.fajerson commented

No immediate plans. But porting it should be fairly trivial - I'll gladly submit a path.

Babalu’s picture

Babalu commented

subscribe

ultimateboy’s picture

ultimateboy commented
StatusFileSize
new admin_message.zip7.06 KB
new admin_message_d5-d6_port.patch16.13 KB

I have ported the module as well as made a few minor modifications: I added a permission to close admin messages and ran everything through a theme function.

I have included the patch file as well as the entire module dir for easy testing.

On a side note, I have quite a few ideas for this module and would be willing to help maintain if needed. Just let me know.

ultimateboy’s picture

ultimateboy commented
Status: Active » Needs review
Babalu’s picture

Babalu commented

thx for the patch, but:

patching file admin_message.js
patching file admin_message.install
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file admin_message.install.rej
patching file INSTALL.txt
patching file admin_message.module
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 61.
Hunk #3 succeeded at 69 (offset -1 lines).
Hunk #4 FAILED at 89.
Hunk #5 FAILED at 102.
Hunk #6 FAILED at 151.
Hunk #7 FAILED at 167.
6 out of 7 hunks FAILED -- saving rejects to file admin_message.module.rej
patching file admin_message_form.js
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file admin_message_form.js.rej
patching file admin_message.info
patching file admin_message.css
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 1 with fuzz 1.

against the dev

ultimateboy’s picture

ultimateboy commented
StatusFileSize
new comment_alter_taxonomy_d5-d6_port.patch13.36 KB

I applied patch to HEAD. Here is an updated patch to dev.

Babalu’s picture

Babalu commented

works. great. thx

ultimateboy’s picture

ultimateboy commented
Status: Needs review » Reviewed & tested by the community

You are quite welcome. As I said before, I am more than willing to help maintain and add new features to this module.

anders.fajerson’s picture

anders.fajerson commented
Category: support » feature
Status: Reviewed & tested by the community » Needs work

Sorry I haven't picked up this. Great work!

ultimateboy, I've given you CVS access to the project.

A quick look at the patch:

* Replacing /* $Id$ * shouldn't be needed, it's handled by CVS.
* While at it, template_preprocess should probably be used together with a tpl.php file.
* "TODO" in descriptions?

Rosamunda’s picture

Rosamunda commented

Subscribing.
It would be great if D6 version could add this patch functionality to incorporate message effects.

darumaki’s picture

darumaki commented

I agree that would be great

czeky’s picture

czeky commented

is it working for You Babalu? for me, its working only for users with permission administer nodes.. ;-(((

Rosamunda’s picture

Rosamunda commented
Title: Port to 6 ? » Admin Message: Porting to 6

Changed title for better tracking.

theemstra’s picture

theemstra commented
Status: Needs work » Reviewed & tested by the community

Patch worked here!
At my friend also!

theemstra’s picture

theemstra commented

INFO: I disabled caching on my site.

mariusooms’s picture

mariusooms commented

Any news on the progress since last November? I think this is the only module in Drupal with these kind of features. Would love to use it for Drupal 6.

Regards,

Marius

ultimateboy’s picture

ultimateboy commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

dev version committed. http://drupal.org/node/392662

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.