ability turn off story URL validation

I agree. We had the same issue. Until this is fixed, you can just 'hack' the module by editing drigg.js. Just remember to note it in case you want to upgrade later.

This has become a non-issue since URL validation has been fixed.

I don't think so,

See the following URLs does not validate :

http://specials.rediff.com/news/2008/jul/11sld01.htm
http://news.cnet.com/8301-1001_3-10004226-92.html

So we should offer a way to deactivate URL Validation on settings.

Hi,

I am not wasting time checking why:

http://specials.rediff.com/news/2008/jul/11sld01.htm
http://news.cnet.com/8301-1001_3-10004226-92.html

Don't work. They either offer a "special guest redirect" or they use broken HTTPD servers.

I agree with the option that needs to be there. I would NEVER turn it on though.

Merc.

We should be careful adding too many options as the admin settings will become overwhelming for our users. This seems to be a very esoteric setting to me.

In my opinion, this should be fixed at the validation stage.

Best,

sicjoy

We should manage error code when page is moved. This patch handles redirect_code returned by drupal. This solves the problem with CNET page.

For the other one (rediff.com), Httpd server seems buggy and does not handle Content-Length to 0.

Hi Sicjoy,

I think it's sensible to turn off validation.
Fixing it at validation is an idea, but I still think it should be possible to turn off URL validation. Too many people asked for it.

Merc.

You're the boss!

--sicjoy

Committed a setting to disable URL http validate.

Committed a setting to disable URL http validate.

Hi cedric,

Sorry about reopening it...
I noticed this:

 if ( variable_get('drigg_trackback_enable', FALSE) &&
      variable_get('drigg_trackback_autodiscovery', FALSE) &&

[...]

   // Fetch the URL (!)
      if (variable_get('drigg_url_validate', TRUE)) {
        $url_request = drigg_url_http_ok($node->url, 'GET', TRUE);
        drigg_debug_msg("HTTP request made to the URL");
      } else {
        $url_request = TRUE;
        drigg_debug_msg("HTTP request NOT made to the URL since drigg_url_validate was OFF");
      }
      $http_request_attempted = TRUE;

Now... this means that if the URL validation is off, there is a side effect here: Drigg won't do the Trackback ping autodiscovery. I can see how somebody might actually want to have validation off, and STILL do the trackback ping autodiscovery. Don't you think?

Why did you add that IF there? I am not asking because I am doubting you, but because you are smarter than me and there's probably a good reason :-D

Bye!

Merc.

Sorry, you are totally right ! I updated my changes... But there might be some side effects to deactivate url validation...

Hi,

That part of Driggi s *the* nastiest one. It's just too complicated... and there's no real way to simplify it :( There's everything that is ugly: global variables, long functions...

Are you doing the final testing for this now?

Merc.

Yes it works for me...