Closed (fixed)
Project:
Views Bulk Operations (VBO)
Version:
5.x-1.0
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
1 Aug 2008 at 15:45 UTC
Updated:
16 Aug 2008 at 21:22 UTC
Jump to comment: Most recent file
Comments
Comment #1
claudiu.cristeaComment #2
infojunkieInteresting issue :-)
I reproduced the behavior on my side, and a little searching revealed that hook_forms is the mechanism used to give different IDs to different instances of the same form. In our case, we need to account for both forms 'views_bulk_operations_view_settings' and 'views_bulk_operations_form'.
I won't be able to look into that request for a while because of my current bug backlog. I will be grateful if you can look into it :-)
Comment #3
claudiu.cristeaThanks kratib... Indeed, the hook_forms() function is the way to fix the issue. I found a very useful story at Drupal 5: How to process multiple instances of the same form on the same page.
I will look into and I will try to provide a patch... Do you have some idea regarding the suffix? Shall we use incremental numbers? Shall we use the view name (...in our case each form instance is a different view)?
Comment #4
claudiu.cristeaI'm here with a first patch... I had used the view name as suffix of the form ID... This will solve my case but... don't know what if there are multiple instances of the same view in the same page... Maybe the numeric incremental suffix can be a better way.
Comment #5
claudiu.cristeaI've also created a patch for numeric incremental suffix (... which I think is the right way!).
PS: I don't think that the 'views_bulk_operations_view_settings' form need to be included in this patch. There is no circumstances where this form should appear in more than one instance on a single page.
Comment #6
infojunkiePretty groovy! Thanks for the patch, seems to be working fine, I'm checking it in and will apply it to D6 as well.
Comment #7
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.