Doing some code review and cleanups (more issues/patches to follow) and noticed that format_plural() was being called incorrectly:

This function ensures that the string is pluralized correctly. Since t() is called by this function, make sure not to pass already-localized strings to it.

CommentFileSizeAuthor
#2 afr_format_plural.patch3.08 KBdrewish
#1 afr_format_plural.patch2.98 KBdrewish
afr_format_plural.patch16.36 KBdrewish

Comments

drewish’s picture

drewish commented
StatusFileSize
new afr_format_plural.patch2.98 KB

woops, that's the wrong patch (it's the basis for the rest of my fixes).

drewish’s picture

drewish commented
StatusFileSize
new afr_format_plural.patch3.08 KB

man bad patch day for me. that one was reversed.

Soren Jones’s picture

Soren Jones commented
Status: Needs review » Fixed

Andrew,

Committed. Thank you very much!

Best,
Soren

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.