The client I'm working for needs a denied state so that once someone has applied for a role they can be marked as denied and not be allowed to re-apply. Doing this will involved some over hauling of the admin page. I'm thinking that some filtering and mass approval/denial ala #273692: Add bulk role approval and denial administrative interface will be needed.

I've got to write it either way but obviously I'd like to get it committed so they'll have an upgrade path so if you've got any feedback or suggestions I'd love to hear them..

CommentFileSizeAuthor
#5 afr_rewrite.patch41.83 KBdrewish
#4 apply_for_role.token_.inc_.txt10.01 KBdrewish
#4 apply_for_role.admin_.inc_.txt8.49 KBdrewish
#4 afr_rewrite.patch22.9 KBdrewish
#3 apply_for_role.module.txt19.76 KBdrewish
#3 afr_rewrite_denies_token_triggers.patch33.71 KBdrewish
#1 afr_major_rewrite_with_denies.patch25.7 KBdrewish
#1 apply_for_role.module.txt18.67 KBdrewish

Comments

drewish’s picture

drewish commented
Status: Active » Needs work
StatusFileSize
new apply_for_role.module.txt18.67 KB
new afr_major_rewrite_with_denies.patch25.7 KB

got the denied bit taken care of and working on turning the admin page into a form so i can add checkboxes to allow multiple applications to be approved or denied at the same time. this is sort of turning into a mega patch because it includes my work from #290378: Make full use of D6's menu and forms systems. once i get everything the way i need it i'll try to work with you guys to break it up and get the parts you like committed. i'm attaching a patched copy of the module so non-devs can review it.

drewish’s picture

drewish commented

i need to rename the approved_date column to processed_date since it doesn't have to only be approved now. while i'm at it i'd like to rename tables and variables from user_role_apply to apply_for_role. i'm guessing the module changed names at one point.

drewish’s picture

drewish commented
StatusFileSize
new afr_rewrite_denies_token_triggers.patch33.71 KB
new apply_for_role.module.txt19.76 KB

this adds token and trigger support.

drewish’s picture

drewish commented
StatusFileSize
new afr_rewrite.patch22.9 KB
new apply_for_role.admin_.inc_.txt8.49 KB
new apply_for_role.token_.inc_.txt10.01 KB

i need to split this up into separate patches now that #290378: Make full use of D6's menu and forms systems has been committed. broke the tokens support into it's own .inc file.

drewish’s picture

drewish commented
Status: Needs work » Needs review
StatusFileSize
new afr_rewrite.patch41.83 KB

it's still a mega patch. added the ability to change from approved to denied and back.

Soren Jones’s picture

Soren Jones commented

No problem. I'll give it a quick test tonight.

Soren Jones’s picture

Soren Jones commented
Status: Needs review » Fixed

Committed!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.