Cache Retrieves Wrong Tags
thebaron88 - August 4, 2008 - 08:53
| Project: | Tagadelic |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
There is a little bug with the cache code. The cache name just used the vid's imploded with no sperator eg,
vids[] = 2;
vids[] = 3;
thus the id is ..._23_...
which would be the same cache name for vocab 23.
The patch fixes this my just using _ as a seperator for the vid's.
| Attachment | Size |
|---|---|
| tagadelic.module.patch | 735 bytes |
#1
Good catch and nice solution.
Can one more person please test this patch and confirm that it:
* does not break a site with existing data
* that the old 231_-type cahced items dissapear after a while: we don;t want them to clutter the cache :)
Bèr
#2
Sorry. Should be "code needs review"
#3
#4
Works for me
#5
Works here too. Except for
* that the old 231_-type cahced items dissapear after a while: we don;t want them to clutter the cache :)
But - if http://drupal.org/node/305380 goes in then they'll go ;)
#6
Applied patch to 6.x-1.2 - cache is cleared correctly (the old ones do disappear).
I believe this one ready to go in ;)
#7
committed to D6 branch.
#8
#9
Automatically closed -- issue fixed for 2 weeks with no activity.