Closed (fixed)
Project:
Tagadelic
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Aug 2008 at 08:53 UTC
Updated:
20 Sep 2009 at 14:40 UTC
There is a little bug with the cache code. The cache name just used the vid's imploded with no sperator eg,
vids[] = 2;
vids[] = 3;
thus the id is ..._23_...
which would be the same cache name for vocab 23.
The patch fixes this my just using _ as a seperator for the vid's.
| Comment | File | Size | Author |
|---|---|---|---|
| tagadelic.module.patch | 735 bytes | thebaron88 |
Comments
Comment #1
Bèr Kessels commentedGood catch and nice solution.
Can one more person please test this patch and confirm that it:
* does not break a site with existing data
* that the old 231_-type cahced items dissapear after a while: we don;t want them to clutter the cache :)
Bèr
Comment #2
Bèr Kessels commentedSorry. Should be "code needs review"
Comment #3
Bèr Kessels commentedComment #4
neochief commentedWorks for me
Comment #5
chrissearle commentedWorks here too. Except for
* that the old 231_-type cahced items dissapear after a while: we don;t want them to clutter the cache :)
But - if http://drupal.org/node/305380 goes in then they'll go ;)
Comment #6
chrissearle commentedApplied patch to 6.x-1.2 - cache is cleared correctly (the old ones do disappear).
I believe this one ready to go in ;)
Comment #7
Bèr Kessels commentedcommitted to D6 branch.
Comment #8
Bèr Kessels commented