The problem for '#type' => 'radio' the id is not being set in theme_radio(), hence ahah.js cannot map the wrapper to an actual DOM element

The problem for '#type' => 'radios': #ahah is not being passed on to the generated radio form items in expand_radios() (D6), nor in form_process_radios() (HEAD).

Patches for both HEAD and D6 attached.

CommentFileSizeAuthor
#8 radio_error_messages_01.patch688 bytescwgordon7
#5 formsapi_radio_ahah_HEAD_1.patch1.06 KBswentel
#5 formsapi_radio_ahah_7.patch1.06 KBswentel
#2 formsapi_radio_ahah_HEAD.patch1.03 KBwim leers
formsapi_radio_ahah_6.patch1.03 KBwim leers
formsapi_radio_ahah_HEAD.patch1.03 KBwim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review

Oops, proper status now!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new formsapi_radio_ahah_HEAD.patch1.03 KB

I forgot about the new "spaces around dots" rule for HEAD. Fixed that.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed this to CVS HEAD and DRUPAL-6. Thanks Wim.

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Critical
Status: Fixed » Needs work

admin/build/testing
notice: Undefined index: #ahah in /includes/form.inc on line 1738.

swentel’s picture

swentel commented
StatusFileSize
new formsapi_radio_ahah_7.patch1.06 KB
new formsapi_radio_ahah_HEAD_1.patch1.06 KB

Using isset() check fixes the notices.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

works for me.

this bug was generating php notices when installing drupal head once it the process reached the "Configure Site" step of install.php.

cwgordon7’s picture

cwgordon7 commented

For some unknown reason, this was committed to both the 6.x branch and HEAD (http://drupal.org/cvs?commit=133188 and http://drupal.org/cvs?commit=133187), and now a fresh 6.x-dev install throws lots of '#ahah' not found errors (e.g. on every single Drupal form). This should be reverted, until a patch that has the bug fixed is submitted. In the future, please do not commit cnw patches without comment.

cwgordon7’s picture

cwgordon7 commented
Status: Needs work » Needs review
StatusFileSize
new radio_error_messages_01.patch688 bytes

Please ignore the last comment, I had not fully read this thread. The patch in #5 is not applicable any more, rerolled instead into one patch.

heine’s picture

heine commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

The patches didn't apply cleanly, so I re-rolled them and committed them to CVS HEAD. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.