The theme_imagecache_scale() function in imagecache_actions.inc has a syntax bug:

function theme_imagecache_scale($element) {
  $output = theme_imagecache_resize($element) .  ', upscale: '. 
  $output .= ($element['#value']['upscale']) ? t('Yes') : t('No');
  return $output;
}

Note that the first line ends with a period rather than a semi colon, so PHP then thinks that the next line is part of that line. Obviously this won't work. Looking through the CVS logs it was actually changed in:

Revision 1.5 - (download) (annotate)
Fri Dec 14 15:15:20 2007 UTC (7 months, 3 weeks ago) by dopry
Branch: MAIN
Changes since 1.4: +4 -2 lines

and those lines haven't been touched since.

FYI I think this syntax bug would have been identified if error_reporting was set higher.

Damien

Comments

fizk’s picture

Status: Active » Closed (won't fix)