Hi!

I recently used your module to give a site ecard features. But I came across some issues:

  • If I use the CAPTCHA Module with yours there is a cosmetic problem because you use $form['block'] as container. I would suggest to remove this and give the submit button a weight. This yould easy integration and theming.
  • Please use .po files and make all strings use the t() function! And all strings should be rewrote so that there is no splitting so multiple use of t() for short strings would be supressed.

I had to rewrite some stuff in your module and had to make a fork for my own purposes. But this is the least thing I like to do...

If you are intereseted I could help you at these issues and provide a german translation :)

At least I will try to provide patches but I am not used to create them and will need time to try out.

Best regards,

Karsten

CommentFileSizeAuthor
#1 ecard-290966-1.patch3.14 KBkars-t

Comments

kars-t’s picture

kars-t commented
Component: Miscellaneous » Code
Status: Active » Needs review
StatusFileSize
new ecard-290966-1.patch3.14 KB

I finally made a patch for the Drupal 5 Ecard module. I did test this on a local drupal installation, did send emails, exportet an .po file and it seems to work finde. I hope this patch is correctly made as this is my first time creating a patch file with diff.

With this it should be easy to translate ecard and if someone shows interest in this I'd like to create a de.po file for this module :)

mssarath’s picture

mssarath commented

Thanks for the patch. I will go through it, and implement it. there are few other patches submitted and few other feature requests. will combine all together and make a release on first week on next month.

thanks,
sarath

kars-t’s picture

kars-t commented
Assigned: Unassigned » kars-t
Status: Needs review » Fixed

I am at it :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.