Do not encode apostrophes

chx - August 18, 2005 - 04:50
Project:Drupal
Version:x.y.z
Component:base system
Category:bug report
Priority:critical
Assigned:chx
Status:won't fix
Description

walkah complained that XML-RPC escapes apostrophes. Steven said it's OK not to do so, so here is the patch. I am quoting the manual:

It takes on one of three constants with the default being ENT_COMPAT:

ENT_COMPAT Will convert double-quotes and leave single-quotes alone.
ENT_QUOTES Will convert both double and single quotes.
ENT_NOQUOTES Will leave both double and single quotes unconverted.

AttachmentSize
check_plain.patch567 bytes

#1

walkah - August 18, 2005 - 17:03

big +1 . the issue is , with ENT_QUOTES .. blogapi users get their apostrophes returned encoded, which is confusing, and frustrating (and then they email me ;) )

#2

chx - August 18, 2005 - 20:18
Status:needs review» reviewed & tested by the community

#3

Dries - August 18, 2005 - 21:35

walkah: does that mean you can remove some cruft from the blogapi.module.

#4

walkah - August 19, 2005 - 02:01

cruft? there's no cruft!

no, this just restores the previous behaviour. (changed by the new XML RPC lib)

#5

Dries - August 19, 2005 - 11:11
Status:reviewed & tested by the community» active

Committed to HEAD. Thanks.

Does this need to be backported (given we backported the xml-rpc library)? I'd think so.

#6

Dries - August 28, 2005 - 16:20
Status:active» won't fix

Unrolled the HEAD patch. Not encoding these is less secure. The problem lies with the XML-RPC clients ...

 
 

Drupal is a registered trademark of Dries Buytaert.