Do not encode apostrophes
chx - August 18, 2005 - 04:50
| Project: | Drupal |
| Version: | x.y.z |
| Component: | base system |
| Category: | bug report |
| Priority: | critical |
| Assigned: | chx |
| Status: | won't fix |
Jump to:
Description
walkah complained that XML-RPC escapes apostrophes. Steven said it's OK not to do so, so here is the patch. I am quoting the manual:
It takes on one of three constants with the default being ENT_COMPAT:
ENT_COMPAT Will convert double-quotes and leave single-quotes alone.
ENT_QUOTES Will convert both double and single quotes.
ENT_NOQUOTES Will leave both double and single quotes unconverted.
| Attachment | Size |
|---|---|
| check_plain.patch | 567 bytes |
#1
big +1 . the issue is , with ENT_QUOTES .. blogapi users get their apostrophes returned encoded, which is confusing, and frustrating (and then they email me ;) )
#2
#3
walkah: does that mean you can remove some cruft from the blogapi.module.
#4
cruft? there's no cruft!
no, this just restores the previous behaviour. (changed by the new XML RPC lib)
#5
Committed to HEAD. Thanks.
Does this need to be backported (given we backported the xml-rpc library)? I'd think so.
#6
Unrolled the HEAD patch. Not encoding these is less secure. The problem lies with the XML-RPC clients ...