walkah complained that XML-RPC escapes apostrophes. Steven said it's OK not to do so, so here is the patch. I am quoting the manual:

It takes on one of three constants with the default being ENT_COMPAT:

ENT_COMPAT Will convert double-quotes and leave single-quotes alone.
ENT_QUOTES Will convert both double and single quotes.
ENT_NOQUOTES Will leave both double and single quotes unconverted.

CommentFileSizeAuthor
check_plain.patch567 byteschx

Comments

walkah’s picture

walkah commented

big +1 . the issue is , with ENT_QUOTES .. blogapi users get their apostrophes returned encoded, which is confusing, and frustrating (and then they email me ;) )

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented

walkah: does that mean you can remove some cruft from the blogapi.module.

walkah’s picture

walkah commented

cruft? there's no cruft!

no, this just restores the previous behaviour. (changed by the new XML RPC lib)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Active

Committed to HEAD. Thanks.

Does this need to be backported (given we backported the xml-rpc library)? I'd think so.

dries’s picture

dries commented
Status: Active » Closed (won't fix)

Unrolled the HEAD patch. Not encoding these is less secure. The problem lies with the XML-RPC clients ...