Closed (won't fix)
Project:
Favicon
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Aug 2008 at 18:14 UTC
Updated:
6 Jun 2013 at 11:17 UTC
How about a D6 release?
While I'm on the subject, I wonder what it would take to make this a D7 core feature?
Comments
Comment #1
robloachIt almost did make it into core (http://drupal.org/node/174940), but instead it was decided to bypass it though .htaccess, returning "The requested file favicon.ico was not found." I'll create the branch today.
Comment #2
mfer commentedInteresting thread. Such pain in the rear issues!
Comment #3
gpk commentedThe main inhibitors to this being in core IIRC were that it requires 2 browser requests to get the favicon and one of them requires a full Drupal bootstrap, even for anon users.
Comment #4
robloachThe best solution would be a .htaccess modification, but this becomes difficult to maintain when you're running hundreds of sites on a multi-site install. I've created the Drupal 6 branch and release, but haven't tested it. So, I expect bug reports!
Comment #5
robloachTwo things need to change in .htaccess for this to work......
RewriteCond %{REQUEST_URI} !=/favicon.icoThis should be documented somewhere.....
Tested and works.....
Comment #6
spidersilk commentedAh, I was wondering why I was still getting favicon 404s in my error reports under D6 despite having this module installed...! Just made the .htacess changes, so let's hope that works.
Comment #7
traviscarden commentedCan I help get the installation process documented? Should I create a patch for an INSTALL.TXT file? Could I help write a handbook page?
Comment #8
kingandyChanges from #5 worked for me, thanks!
@Travis, there doesn't seem to be an INSTALL.TXT now so I don't think it's a case of a patch. Just creating a file with the instructions from #5 should be sufficient. (Though, that said, I can't count the number of times I've scoured Drupal.org for something like this before even checking to see if there is an INSTALL.TXT file for the module ... a note on the project page would probably help too!)
Comment #9
fax8 commented#5 worked for me too.
This should be documented. Please add the following in the Project page and in a new INSTALL.txt.
Installation on Drupal 6.x:
1 - install the module (guide: http://drupal.org/node/70151)
2 - open with a text editor the .htaccess file located on your drupal root (Some file managers hide files starting with dots .. so be sure to enable showing them)
3 - comment out (adding a # to the beginning of the line) the following lines in .htaccess
and
Setting this as critical as without this informations users are unable to use successfully the module.
Comment #11
traviscarden commentedThank you for contributing, @simanta, but your comment doesn't belong in this issue. (This issue is about adding documentation to the favicon module, not features.) Please delete its contents and file a new issue as a feature request.
Comment #12
leehunter commentedSimanta has made a page for this (http://drupal.org/node/718088) and I've pasted in the code and moved it to the theme snippets section of the theming guide so I'm deleting the message in this queue.
Comment #13
klonosIs this supposed to resolve the issue where no favicon is displayed in IE or simply to deal with 404 errors?
Comment #14
VTM commentedHi,
I did the installation and commented out the required rows in the .htaccess file, and it is not working for me.
Where do I put the required favicon file?
Must it has the name "favicon.ico" or I can rename it to anyname.ico?
What should I do with the settings of the theme(s)?
Does it need some time/F5s(refresh) to show the favicon?
thanks.
Comment #15
traviscarden commentedWe would be happy to help you, @VTM, but please create a new issue rather than hijacking one we're trying to work on. Thank you.
Comment #16
VTM commented@ Travis: No hijacking. The answers to my questions should be included in the INSTALL.TXT file. Thank you.
Comment #17
traviscarden commentedI can appreciate that, @VTM, but that needs to be said then. It turns out that question pertains more to the theme system than favicon module. We would move the issue to the appropriate place for you, but then we would lose all the work that we've been doing on our task. That's what I mean by "hijacking". Please read about using the issue queue in the handbooks if you don't understand them. Specifically see How to make an issue report. And please don't take over this issue again. Thank you.
@Rob Loach, do you suppose we can expedite this issue? It seems like it's just promoting confusion.
Comment #18
traviscarden commentedComment #19
dmitriy.trt commentedSubscribing
Comment #20
johnennew commentedClosing this old issue - instructions are in the README.txt and project main page. Probably worth opening a new issue if anyone feels something here is not resolved.