Trying out Drupal 5.9.

I installed jquery update 5.x-2.x and enabled it which is the prereq for WYMEditor 5.x.2.0 I believe.

Then installed WYMEditor 5.x.2.0 and enabled it.

Then received the following PHP warning:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in C:\Web\WebServer\Apache22\htdocs\Drupal59\sites\all\modules\wymeditor\wymeditor.module on line 169

Can anyone shed light on this? I guess recent version of PHP may have changed a little?
Thanks

CommentFileSizeAuthor
#5 wym-5-passbyref-1.patch432 bytesadrinux

Comments

jacobmn’s picture

I had this same issue and I determined the problem...

I quote this guy:

The classes do not pass arguments by reference.

If you are passing arguments by reference to the class functions, you do not need to do that. Just remove the & character from the function call arguments.

As such, go to line 169 of your wymeditor.module file and remove the ampersand from this line:

_wymeditor_input_format_alter(&$form[$key]);

It should then look like:

_wymeditor_input_format_alter($form[$key]);

And you are set. This should probably be a bug that gets fixed but I am not sure how to go about making that happen. Glad it was simple enough to fix anyhow.

billybob4’s picture

Lovely. Thanks for the tip :)

billybob4’s picture

Status: Active » Closed (fixed)
adrinux’s picture

Status: Closed (fixed) » Needs review

I just hit this bug in wymeditor when moving my site from dev to live server, a whole section of the site white-screened :)

The full error message from apache's error log:

HP Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /var/www/multi5/sites/all/modules/wymeditor/wymeditor.module on line 169, referer: http://dev.perlucida.com/admin/build/modules

This is on a server running debian etch, using the php package 5.2.0-8+etch13. It seems nonsensical to re-enable a deprecated feature when the fix is so trivial.

Attached is a patch for wymeditor 5.2, from browsing cvs it looks like this code has been re-written for the 6.x-dev version.

adrinux’s picture

StatusFileSize
new432 bytes

and of course the patch...[sighs]

duaelfr’s picture

Status: Needs review » Closed (won't fix)

This version of WYMeditor is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.