I'd like to be able to run tests by file name, not by class name or group name, in scripts/run-tests.sh

CommentFileSizeAuthor
#8 291670.patch231 bytesswentel
#1 select-tests-by-filename-291670.patch1.66 KBdlhubler

Comments

dlhubler’s picture

dlhubler commented
StatusFileSize
new select-tests-by-filename-291670.patch1.66 KB

Also fixes small bug i noticed, selecting tests by class name had wrong keyname (class_name v.s. class)

dlhubler’s picture

dlhubler commented
Status: Active » Needs review
dlhubler’s picture

dlhubler commented
Project: Test driven development infrastructure » Drupal core
Version: » 7.x-dev
Component: Code » simpletest.module

I incorrectly had this under "Testing Infrastructure", moving to Drupal proper

moshe weitzman’s picture

moshe weitzman commented

looks good to me. i only did a code review.

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Reviewed & tested by the community

Fair enough for me, and also fixes a bug (--class had no effect).

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

I removed some tabs, extended the documentation a bit and committed this to CVS HEAD. Thanks.

swentel’s picture

swentel commented

Shouldn't there be this at the top of the file:

#!/usr/bin/php

easier to run ;-) (and we do it for all other files too)

swentel’s picture

swentel commented
Status: Fixed » Needs review
StatusFileSize
new 291670.patch231 bytes

Patch adds #!/usr/bin/php at the top.
Trivial patch of he month ?

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Fixed

There is no sane default for this. On Mac OS X for example, this will default to the system PHP binary (old for Tiger, more recent for Leopard), not to the one you use in MAMP. It's better to have no default at all.

On the other hand, it would be cool if you could find a way to automatically detect the path of the PHP binary which is used to run the script. We need that information down the road (see comments in the file), and we currently default it badly to /usr/bin/php.

swentel’s picture

swentel commented

Fair enough, but should'nt we remove it then from drupal.sh to be consistent in core ?
Oh well, this is trivial of course :)

damien tournoud’s picture

damien tournoud commented

No really: it's critical for Simpletest to run on the good PHP interpreter. It's not that critical for drupal.sh.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.