Multiple instances of PicLens javascript from drupal_set_html_head
dldege - August 6, 2008 - 16:13
| Project: | Cooliris (PicLens formerly) |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
I added piclens support to the node_view of my particular node type. When view /node I get multiple instances of the piclens javascript in the head.
<script type="text/javascript" src="http://lite.piclens.com/current/piclens_optimized.js"></script>
<link rel="alternate" type="application/rss+xml" title="dev - mediaRSS" href="http://localhost/sliderdev/piclens/slider_piclens/579" />
<script type="text/javascript" src="http://lite.piclens.com/current/piclens_optimized.js"></script>
<link rel="alternate" type="application/rss+xml" title="dev - mediaRSS" href="http://localhost/sliderdev/piclens/slider_piclens/560" />This is because a check for duplicates is not made nor is drupal_add_js() used and/or does not support external JS files.
#1
I'll use a static var to fix the inclusion of the piclens javascript.
The multiple rss feed links are ok to stay, right ?
(changed version to dev also, since I'm going to work on that - it has way more features and bugfixes allready and this should be included in next release - at least the D5 version)
#2
commited to drupal 5 and 6 branch, thanks for the report!
#3
Yes, each feed should be listed. I will test this new version. Thanks.
#4
This is fixed in my testing. Thanks.
#5
Automatically closed -- issue fixed for two weeks with no activity.