Closed (fixed)
Project:
Cooliris (PicLens formerly)
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Aug 2008 at 16:13 UTC
Updated:
21 Aug 2008 at 16:43 UTC
I added piclens support to the node_view of my particular node type. When view /node I get multiple instances of the piclens javascript in the head.
<script type="text/javascript" src="http://lite.piclens.com/current/piclens_optimized.js"></script>
<link rel="alternate" type="application/rss+xml" title="dev - mediaRSS" href="http://localhost/sliderdev/piclens/slider_piclens/579" />
<script type="text/javascript" src="http://lite.piclens.com/current/piclens_optimized.js"></script>
<link rel="alternate" type="application/rss+xml" title="dev - mediaRSS" href="http://localhost/sliderdev/piclens/slider_piclens/560" />
This is because a check for duplicates is not made nor is drupal_add_js() used and/or does not support external JS files.
Comments
Comment #1
swentel commentedI'll use a static var to fix the inclusion of the piclens javascript.
The multiple rss feed links are ok to stay, right ?
(changed version to dev also, since I'm going to work on that - it has way more features and bugfixes allready and this should be included in next release - at least the D5 version)
Comment #2
swentel commentedcommited to drupal 5 and 6 branch, thanks for the report!
Comment #3
dldege commentedYes, each feed should be listed. I will test this new version. Thanks.
Comment #4
dldege commentedThis is fixed in my testing. Thanks.
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.