Closed (fixed)
Project:
Login Destination
Version:
6.x-2.1
Component:
Miscellaneous
Priority:
Critical
Category:
Support request
Assigned:
Reporter:
Created:
6 Aug 2008 at 16:50 UTC
Updated:
27 Jun 2012 at 08:22 UTC
Jump to comment: Most recent file
Comments
Comment #1
BluesmanEP commentedI am having the same problem. I upgraded from version 6.x-2.0 (which was working properly) and now can't access the admin page from the menu, or the URL.
Thanks,
Evan
Comment #2
ardas commentedDid you try to clear your cache?
Comment #3
ardas commentedAfter enablling the module try to click Ctrl+F5 (FF, IE).
Comment #4
ardas commentedEverything works fine, I've just checked.
Changing it to won't fix untill the detailed bug scenario is provided.
Comment #5
spopovits commentedI tried the ctl F5 and still nothing happens differently. The module is active and after log in user is taken to site/user page which I am assuming is the default.
I cannot administrate this function . The site is www.mistakehawk.com if you wish to see it. Also I have logintobogen and front_page modules installed, if that gives you more information.
Comment #6
spopovits commentedWhat other information do we need to evaluate/provide to demonstrate that the administration of the module does not show up.?
Comment #7
apollonet commentedSame problem here.
I just installed the module and i can't find the admin page.
I went on /admin/user/login_destination and i tolds me 'access forbidden"...
Comment #8
Lappie commentedSame problem as #7 and original author.
I've diffed the earlier version 2.0 that was mentioned to work and the latest and noticed that the following piece of code was missing in the newer version.
Adding this to the newer version did pop up the permission in the permissions dialog of Drupal, but then still no luck regarding the admin page of the login destination module. The
admin/user/login_destinationurl now gives just the user mgmt page instead of 403.So apparently there have been (unintentional) code deletions going from 2.0 to 2.1
Comment #9
Wutimer commentedHaving the same issue; the admin menu item and settings page do not exist.
Running node_privacy_by_role if that has anything to do with "access denied" when trying to navigate directly to /admin/user/login_destination
Comment #10
dmendez commentedI had the same issue and it seems to be related to the issue this person had: http://drupal.org/node/274869
Apparently the Drupal menu system in later versions of Drupal 6 now requires that all menu items have access control. The main menu item for login destination did not have any access control, therefore it does not display.
Here is the fix that worked for me.
1) Add this code to login_destination.module after the variable definitions near the beginning of the file. This defines a new permission.
2) Change this:
to this (this checks for the above permission before displaying a link to or allowing access to this admin page):
3) Disable, then re-enable the module.
4) Add the new permission 'administer login destination' to your role.
Now you should be able to access the administration page. I would have created a .patch file for this, but I have never done so and have no clue as to where to begin. Could this be added to the main project?
Comment #11
BluesmanEP commentedThis worked perfectly!
Thanks for tracking this down.
-Evan
Comment #12
Lappie commentedcopy that!
Comment #13
spopovits commentedThank you for the code...it worked like a charm!
Comment #14
spopovits commentedMy issue is resolved. I am not sure who should close this or how the patch gets created either , so I will defer to the drupal gurus to do what they will with this particular issue.
Again thank you drupal community!
Comment #15
ardas commentedDamn! I don't know why but old source code get into DRUPAL--6-2-1 tag.
I'm now creating DRUPAL--6-2-2 trying to solve this issue.
Comment #16
ardas commentedI am having strange issues with CSV.
I'm updating DRUPAL--6-2-2, than changing code and then trying to commit to this tag. and I'm receiving this error:
cvs commit: sticky tag `DRUPAL-6--2-2' for file `login_destination.info' is not a branch
cvs [commit aborted]: correct above errors first!
Does anybody know how to solve this?
I'm attaching the latest source code to this comment
Comment #17
matt bthe admin page disappeared when I upgraded drupal to v6.4 - this fixes it (thanks!)
Comment #18
motto commenteda+
Comment #19
francewhoaSubscribing. Same thing here with Drupal 6.4 & module version 6.x-2.1 (2008-Aug-04)
'Access Denied' when visiting http://mywebsite.com/admin/user/login_destination
Screenshot attached.
Comment #20
francewhoaI have attached the fixed module below. This is unofficial fix of version 6.x-2.1 (2008-Aug-04). Thanks to dmendez for the code.
Works for me with Drupal 6.4:
Comment #21
francewhoaRestoring issue title.
Comment #22
jefbak2 commentedunofficial is working for me on drupal 6.4. Thanks!
Comment #23
Rob T commentedUnofficial working for me in 6.3!
Comment #24
joshmillerThis worked well for me too!
Josh
Comment #25
wallbay1 commenteddoesn't work for me at all
still having the same problem (drupal 6.4) there is no link with user_destination
Comment #26
raymo commented(Drupal 6.4) Unofficial not working for me. There is no link to login settings on admin page and when I try to go to the user/login_destiniation, access is denied. Any ideas?
Comment #27
mk1000 commentedNo it works for me after
doning upgrade.php.
Maybe it helps you too.
markus
Comment #28
marcp commentedThe issue is that, from Drupal 6.2 and on, every menu item must be correctly secured by access control as per http://drupal.org/node/109157
What's required is to add one line to
login_destination_menu()in login_destination.module. Right after the line that says:add:
After doing this, you'll need to disable and re-enable the login_destination module in order for the menu cache to be rebuilt.
It looks, from the comments above, that there used to be a separate permission for securing this menu item. Since that permission was removed, it seems like the module author would like to allow any user who can "administer users" to also administer login destinations.
I started with the Acquia-approved Drupal 6.4 installation, so login_destination is unusable right now on new versions of Drupal 6.x.
Comment #29
paulnem commentedApplying the fix from #28 has resolved this for me. Would be good to get it updated in the release.
Comment #30
andrewfn commentedThe fix from #28 worked for me. Is there any reason this is taking so long to get committed?
Comment #31
Michael Phipps commentedSince no-one has actually provided an actual patch file (there's been code submitted, but not in the format of a patch), I thought I'd throw one together based on the code from #10 which works quite well.
I hope this can get us closer to having this issue resolved!
Comment #32
paulnem commentedSee #16, ARDAS is the module owner and is having issues committing the code.
Comment #33
the1who commentedI have followed what you have said in #26, but maybe I need to read further into the access permission node posted below with the changes for the latest at least, 6.6 that I am running.
I get the following errors:
* warning: Missing argument 1 for drupal_get_form() in /home/user/public_html/includes/form.inc on line 69.
* warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, '' was given in /home/user/public_html/includes/form.inc on line 366.
If someone could guide me a bit further that would be greatly appreciated. This isn't the site in my profile, the site is here:
www.bsarc.us
Thanks for your time and in advance, your help.
Comment #34
perandre commentedCan't get fix to work with D6.6. Subscribing...
Comment #35
marcp commentedRegardless of whether you choose the patch in #31 or the fix in #28, you will need to clear your cache_menu table. The easiest way to do this is to disable and re-enable the login_destination module.
Comment #36
the1who commentedI have done that, even going to the /admin/build/menu directory and editing that, which according to all the other documentation, clears it as well as the option of enabling and disabling. I still get the error you know.
Matthew
Comment #37
marcp commented@the1who - there's nothing specific in the error messages that you posted to say that it's LoginDestination that's the problem for you. Try starting over with a fresh 6.6 installation and just install LoginDestination and the patch in either #28 or #31. It should work. Then you can backtrack and see what's different between the fresh installation and your site that is having problems.
Comment #38
perandre commentedNow it works, must have forgotten this step last time! Thanks.
Comment #39
the1who commented@perandre, can you let us know what you did? maybe it might help me.
Comment #40
perandre commented@the1who, I uninstalled (and deleted) the module, added the line mentioned in #28 and installed again. Worked for me on D6.6.
Comment #41
the1who commented@perandre, ok, thank you very much or that information. I will give the steps you mentioned a try tonight. Thanks.
Matthew
Comment #42
the1who commented@perandre, One night delayed, but I have done what you have mentioned and I have fixed my error in applying the modification to the module. I had some how, taken what is mentioned in the access line to add, to overwriting the page_argument line instead. I wish I would have noticed that sooner, and that is what created the errors on my end I am sure of. Thanks for time and advice.
Matthew
edit, with latest releases tonight:
D6.6
LD 6.x-2.1 2008-Aug-04
Modifying module with #28
Comment #43
paulnem commentedI think we've all tested this enough, it works. When will it be added to dev because more and more people will find the problem as they start upgrading or using it.
Comment #44
marcp commentedI've requested co-maintainer status here: #332164: I volunteer to co-maintain LoginDestination
I don't think this project has been abandoned, but if it has, then we should wait 2 weeks before requesting that someone else be given ownership -- http://drupal.org/node/251466 -- anyone else want to take over ownership of this or request co-maintainership? I've got my plate full already.
Comment #45
borisbarowski commentedusing drupal 6.6, the fix in #28 works (as was established, but extra confirmation is always nice)
Sorry, i'm to inexperienced to be given maintainer status
Comment #46
marcp commentedThanks for the extra confirmation -- it is definitely helpful.
I moved the request for co-maintainership over to the Webmaster queue. Hopefully we'll be able to get a release out soon. I'm going to put in the fix from #28 because I don't think we need a separate permission for this. My only real question would be -- should we use 'administer users' or 'administer site configuration' for the access check?
Comment #47
borisbarowski commentedI vote for administer site configuration.
I think of this module as more than just user management, but adding site specific functionality
Comment #48
marcp commentedAgreed that we should go with 'administer site configuration' for this.
Comment #49
cgjohnson commentedI am using the latest version of login destination and D6.6 and I can't see the admin settings either -- I can't even see the module in the list when I run update.php (it is there, enabled, on the module page). Any updates on this problem? Seems to be the same bug. thanks.
*Update: When I add the fix in #28, it works -- but I'm confused about why that's not already integrated in this latest version. To add the fix, I removed a line that said:
'access arguments' => array(LOGIN_DEST_PERM_ADMIN),
Will what I've cause any problems? thanks in advance for your help.
Comment #50
marcp commentedI suspect the line that you removed was a line that you added at an earlier time. If you just start with the 6.x-2.1 version of the code and make that one line addition then you should be fine.
The maintainers have yet to put out a new release for this module that fixes the bug. I have requested co-maintainership so we can get a working release out the door. The issue is on the webmasters queue now: #332164: I volunteer to co-maintain LoginDestination. I don't think it would hurt for you to reply to that thread to nudge the webmasters.
Comment #51
geodaniel commentedSubscribing
It'd be good to get the latest release of the module working, and if ARDAS is having issues committing, perhaps he can let marcp in to make these minor adjustments to get the module to work?
Comment #52
marcp commentedI just noticed that there is a new release of this module.
I haven't tried it out yet, but I suspect the issue is fixed. Looking at the diff, you'll need to assign users 'administer login destination' rights in order for them to be able to administer login destination.
Comment #53
prodosh commentedI had the unofficial patch working until I recently upgraded to the latest version of the module. Now it doesn't redirect as defined in the login_destination admin screen. No matter what one specifies one always ends up on the http://example.com/user page.
Comment #54
the1who commentedYeah, I haven't gone into the code much further, but I am getting the same issue. The admin pages are showing to show that i have the settings in there for the redirection, but it only goes to user page. You're not alone pban02. I'll try looking at my own side of the code a bit more when I can possibly tomorrow.
Matt
Comment #55
webengr commentedjan 12, 2009,
using either the stable 5.x-1.1 or the dev, 2008-Dec-012008-Dec-01
I also am not able to see admin page with Drupal 5.12
I updated to 5.14, no change. This may be a new thread under drupal 5 for project...
Alright this is weird,,,,
I uninstalled, used the earlier version, 5.x-1.0 that seems to work, then updated to 5.x-1.1, now I see it in the menu.... I don't know maybe I goofed and just thought I saw the error... I'll leave this post here in case someone else sees it.
Comment #56
francewhoa@ardas (Module maintainer): Following up on your comment: http://drupal.org/comment/reply/292006/970509#comment-970509
The "Login Destination" module version 6.x-2.x needs critical update. Have you figure out how to commit your patch with CSV? Did someone get back to you?
Another patch here. Might work: http://drupal.org/node/341683#comment-1501838
@all: I sent an email to ardas (Module maintainer) on June 17, 2009 asking him to reply in this issue.
Comment #57
mhartman2009 commentedComment #58
mhartman2009 commentedComment #59
Anusha Isaacraj commentedThanks a million dmendez for the code... !
Works Perfectly :-)