How possible would it be to get a backport of this to Drupal 5?

CommentFileSizeAuthor
#11 pingfm.zip21.57 KBonelittleant
#12 pingfm.zip21.51 KBonelittleant
#2 pingfm.tar_.gz14.1 KBshane birley

Comments

robloach’s picture

robloach
he/him
commented

Very possible, if someone backports it.

shane birley’s picture

shane birley commented
StatusFileSize
new pingfm.tar_.gz14.1 KB

First crack at it.

Coding by Roberto Gerola of Speedtech.it

Sponsored by Left Right Minds.

robloach’s picture

robloach
he/him
commented

Hi Shane, great work! You mind maintaining the Drupal 5 branch? I just added you to the CVS access list :-) . If you'd like, I could stick this in the branch to start it off....

shane birley’s picture

shane birley commented

Sounds good to me!

Roberto Gerola’s picture

Roberto Gerola commented

I fixed a minor issue : firing only on insert of news nodes now.
Updated version : http://speedtech.it/sites/default/files/pingfm-5.x-dev.tar.gz

Roberto

shane birley’s picture

shane birley commented
Status: Active » Fixed

This is now closed. Please feel free to download the Drupal 5 port.

robloach’s picture

robloach
he/him
commented

Shane, I don't see the DRUPAL-5 branch around. Am I missing something? I just put in a rather large fix which abstracted out hook_pingfm_custom_url(), which wouldn't be in http://speedtech.it/sites/default/files/pingfm-5.x-dev.tar.gz .

shane birley’s picture

shane birley commented

Yah, soon after I said I would help, my CVS borked and I only recently got it working again (sort of). I thought I had branched it. I will try it again and see if my CVS is working again.

robloach’s picture

robloach
he/him
commented

Yeah, I know how difficult getting the CVS working is. If you have any troubles, feel free to hit up #Drupal on IRC. I could also make the branch if you wanted....

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

onelittleant’s picture

onelittleant commented
StatusFileSize
new pingfm.zip21.57 KB

Made some modifications to the backport to get it working for us. Eliminated a D6 API call to get around a whitescreen on posting. Refactored URL pattern replacement to enable absolute URLs and eliminate an ?Array query string on URL replacements.

Download the attachment in #12. This one has a bug.

onelittleant’s picture

onelittleant commented
StatusFileSize
new pingfm.zip21.51 KB

Sorry, had a bug in #11. Use this one.

robloach’s picture

robloach
he/him
commented
Status: Closed (fixed) » Fixed

Thanks! http://drupal.org/cvs?commit=343340 http://drupal.org/node/746608

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.