Files are not deleted when replaced

I traced nonsie's issue back to field_file_save()... it doesn't know that a file is a replacement so it can't call field_file_delete() which would take care of removing the admin image.

because the file is removed from the node not, deleted. this will change before release but is how it works currently.

it's clearly a bug.

marked #292539: File not removed from filesystem on file remove and #293176: Files not delete in database and directory as duplicates

This is a beta blocker. Need to track removed files in form_state and on #submit field_file_delete them.

marked #297655: Delete the files in the directory and in the files table as a duplicate

Hello,

i don't understand what beta blocker mean.

Can you explain that.

Thank you.

Klaus

Hello,

I see there is now an alpha4.

My question is now when it is planed that the "file delete problem" will be fixed.

I think on a production site where users can upload files and remove them it is not possible to work with this module at the moment.

best regards

Klaus

marked #306313: Replacing a file with a new upload doesn't remove the previous one. as a duplicate

Files still not deleted when replaced in 6.x-3.0-alpha5. Would be happy to test patch if any.

When i press delete button in edit node page and press save image dont't show in node view, but in BD table=files deleted files status=1 (active, used). This is not possible to remove unused files.

yep file delete's aren't happening yet.. It's sorta by design.. I meant to have a filebrowser in place by now.. but haven't gotten around to it.. I'll get the delete functionality in fairly soon I think..

marked #318044: Files are not deleted as a duplicate

marked #340499: Deleting image from field does not remove file as a duplicate.

marked #327022: temporary uploaded files not deleted as a duplicate

subscribing

Subscribing

This summer I amended either this module for D5 or the Image Attach (can't remember which) to do what we need done here. I am wondering if there is any work already being done on this or if I should just go ahead and do it this weekend? (If so I will create it for D6 and if I did create it this summer for this module already I will provide what I did for D5 as well. Thoughts?

Trevor

[subscribing]

Andrew Morton says this bug is vital for drupal.org to start get using FileField / ImageField.

subscribing

marked #359811: filefield does not delete file on node delete as a duplicate

Any update on this bug?

Not applicable to upgrade, since we found that keeping image module for now works once we fixed its upgrade path.

Subscribing.

fixed in HEAD.

Hello dopry:

I have tested filefield 6.x-3.x-dev and I'm think that this issue is not completly solved.

First, when I create a new node, files uploaded with filefield are not attached to the nodes, and php displays an invalid foreach() warning.

I have created a small patch that solves this bug, but there is another problem.

When users replace a file without submit the node (the first time), files are not deleted.

For example:

go to: node/add/page
upload a field with filefiled.
replace this file with another one
submit the node

The first file is still in the table {files} and in the disk.

I have marked my pacth as (code need work) because it doesn't solve the second issue.

hmm... but that file would exist marked as temporary in the files table, and that's expired by system_cron(), AFAICT.

I did not know of this characteristic. I see that was introduced in Drupal 6.

Well in this case, I'm think that the last patch will be enought to solve the issue.

Changing status.

committed to HEAD with modifications.

Even on a cron run using the 6.x-3.x-dev (2009-Feb-06) version, I am still seeing files on the server if a file is added, removed, another added and then the node is saved... http://drupal.org/node/369450

This is how system_cron() works

function system_cron() {
  // Cleanup the flood.
  db_query('DELETE FROM {flood} WHERE timestamp < %d', time() - 3600);
  // Cleanup the batch table.
  db_query('DELETE FROM {batch} WHERE timestamp < %d', time() - 864000);

  // Remove temporary files that are older than DRUPAL_MAXIMUM_TEMP_FILE_AGE.
  $result = db_query('SELECT * FROM {files} WHERE status = %d and timestamp < %d', FILE_STATUS_TEMPORARY, time() - DRUPAL_MAXIMUM_TEMP_FILE_AGE);
  while ($file = db_fetch_object($result)) {
    if (file_exists($file->filepath)) {
      // If files that exist cannot be deleted, continue so the database remains
      // consistent.
      if (!file_delete($file->filepath)) {
        watchdog('file system', 'Could not delete temporary file "%path" during garbage collection', array('%path' => $file->filepath), 'error');
        continue;
      }
    }
    db_query('DELETE FROM {files} WHERE fid = %d', $file->fid);
  }
  $core = array('cache', 'cache_block', 'cache_filter', 'cache_page', 'cache_form', 'cache_menu');
  $cache_tables = array_merge(module_invoke_all('flush_caches'), $core);
  foreach ($cache_tables as $table) {
    cache_clear_all(NULL, $table);
  }
}

DRUPAL_MAXIMUM_TEMP_FILE_AGE in seconds is:

define('DRUPAL_MAXIMUM_TEMP_FILE_AGE', 21600);

Then, you have to wait at least 6 hours to delete a file with system_cron()