Thank you for this module.

I have a problem with phone and fax numbers : they are stored as integers.

This cause several problems :
- leading zeros are ignored
- spaces to format numbers cause errors (ex : 02 40 56 17 30 is saved as 2)
- optional characters +()# ext cannot be saved
- numbers cannot be longer than 11 digits

Can you store them as strings, with at least 20 characters per number.
Another welcome addition should be a mobile phone number.

Frederic

Comments

brmassa’s picture

brmassa commented

Frederic,

nice comments. i will fix it.

But i still might filter the input for numbers only, to avoid inserting letters. Im focusing on split the display from the data itself. The displays can be changed, country-based. However, i might need help to build the display customization from people.

regards,

massa

flebas’s picture

flebas commented

I think filtering should allow entering of numbers in canonical format. At least you should allow + - ( ) and space.

Examples :
+1 (416) 467-5100
+33 (0) 297 12 35 55

Input of letters may be useful if using letters instead of numbers : (800) DRUPAL1 or to indicate an extension or an information about the number : +1 (416) 467-5100 ext 5114 or +33 (0) 297 12 35 55 (home)

I think you should not look for formating numbers, rules are quite complex and are changing. Just publish numbers as they are entered.

Frederic

brmassa’s picture

brmassa commented
Assigned: Unassigned » brmassa
Status: Active » Fixed

Frederic,

You convinced me. i just changed the code on CVS.I will, however, probably build a function to filter the phone to numbers, since its required on many external APIs.

regards,

massa

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.