Download & Extend
Javascript Tools » Issues

tabs module - theming tab link problem - missing <span class="tab">

Posted by mattez on August 7, 2008 at 5:17pm
Project:Javascript Tools
Version:6.x-1.0
Component:Tabs
Category:bug report
Priority:critical
Assigned:Unassigned
Status:active

Issue Summary

hi... if you find you your tabs displaying wrong, with no background, no tab-right.png. It cause in this module is missing inner span in tab link. Drupal tabs use this inner span to format background. In modules\jstools\tabs is (line 140):

$output .= '<li'. drupal_attributes($element[$key]['#attributes']) .'><a href="#tabs-'. $element['#tabset_name'] .'-'. $element[$key]['#index'] .'">'. $element[$key]['#title'] .'</a></li>';

and shut be:
$output .= '<li'. drupal_attributes($element[$key]['#attributes']) .'><a href="#tabs-'. $element['#tabset_name'] .'-'. $element[$key]['#index'] .'"><span class="tab">'. $element[$key]['#title'] .'</span></a></li>';

After adding this tabs looks OK.. like other Drupal tabs.
Im not sure how to prepare fine patch..sorry.

Login or register to post comments

Comments

#1

Posted by mattez on August 7, 2008 at 5:18pm
Title:tabs module - theming tab problem - missing <span class="tab">» tabs module - theming tab link problem - missing <span class="tab">

#2

Posted by zuk0 on September 21, 2008 at 9:40pm

That helped me with tabs module for drupal 6.0. Thank you.

#3

Posted by kuzma on June 3, 2009 at 4:15pm
Version:5.x-1.x-dev» 6.x-1.0

Fixed it for me on Drupal 6 as well