Multiple Start Slideshow links on one page is not supported

dldege - August 7, 2008 - 18:19
Project:Cooliris (PicLens formerly)
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

I'm using this code

    $node->content['slider_piclens_start'] = array('#value' => mediarssapi_piclens_lite_link('', FALSE));

So that each of my piclens enabled nodes can fire off its slide show. This works for a single node page view but not a view or /node page where more then one node is displayed with the link. This appears to be that these links are missing the id of the feed to start.

#1

swentel - August 7, 2008 - 18:56

The easiest solution will be to introduce a third argument in that function where you can pass along the the url of the feed. Your url should look like 'piclens/yourmodule/yourargs' then. I'll get this fixed in the weekend normally.

#2

swentel - August 7, 2008 - 19:18
Status:active» needs review

Hi, can you test the attached (untested) patch ?
You need to add a third argument to the function as mentioned in #1

AttachmentSize
piclens_individual_feed.patch 1.72 KB

#3

dldege - August 7, 2008 - 19:50

That worked - nice!

Output is now

<a href="javascript:PicLensLite.start({feedUrl:'http://localhost/sliderdev/piclens/slider_piclens/579'});">Start Slideshow <img width="16" height="12" border="0" align="absmiddle" title="PicLens" alt="PicLens" src="/sliderdev/sites/all/modules/drupal-contrib/piclens/PicLensButton.png"/></a>

#4

swentel - August 7, 2008 - 20:11
Status:needs review» fixed

great,
commited to D5 and D6 branch. Thanks for the report and the test!

#5

Anonymous (not verified) - August 21, 2008 - 20:13
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.