Cannot select image files to upload

have you solved the issue?

I have this issue too.

It seems that Opera on the PC enforces the file types for the image fields incorrectly. If the image field has "Permitted upload file extensions" set then Opera refuses to show any files at all.
Setting the file extensions to nothing allows files to be selected. This fixes the issue but runs the risk of users submitting any kind of file into the image field !

Frankly I think this is an Opera bug, but it way well be Windows at fault (XP in my case).

I'd like the project maintainer to tell us if disabling the types is as risky as I think it is? My concern is for files that will also be run through imagecache for scaling afterwards.

I'm using Opera 9.52 on XP.

Has anyone got a test site set up to demo this problem?

Creating a copy of the page (just copy the source to a new html page) and changing the values for the file input type from accept="jpg|jpeg|png" to accept="jpg,jpeg,png" makes Opera work correctly, but it breaks Safari & probably other browsers.

I have had a look around to see how the accept="…" should be formatted, but it is unclear to me. It seems that HTML (4 at least) expects comma separated, but they should be formatted as mime types eg image/jpg, image/jpeg… I cannot tell what XHTML expects, since it seems to inherit the specs from HTML & other RFC's.
Is it the case that using pipes "|" means that the browser should interpret the values as extensions instead of mime types?

I'm still unclear if this is an Opera bug or incorrect markup.

My main site admin loves Opera, so it would be nice if it worked :)

Subscribing

the same problem...

I think the line 714 imagefield.module should looks like this:

'#attributes' => array('class' => 'imagefield imagefield-'. $fieldname),

w/o accept parameter.

PremAnup that looks correct,

Sorry I can't test right now but I'll try in the next couple of days.

I wonder if changing the following.

on line 714,
'accept' => str_replace(' ', '|', trim($field['widget']['file_extensions']))
… to …
'accept' => str_replace(' ', ',', trim($field['widget']['file_extensions']))

Looking at the html 4 specs, it seems commas should be used for the separator in the 'accept' mime type list.
http://www.w3.org/TR/REC-html40/interact/forms.html#adef-accept
Is that the case for XHTML 1.0 Strict ?

I guess if it works it must be right :)

OK here is the problem as I see it.
Removing the 'accepts=' property will work, but then you could also just remove the permitted extensions in the image field settings, you get the same effect without hacking the module.

The accepts parameter should be separated by commas, so my comment #9 will work, accept for one problem. There is a javascript validation happening, that is preventing images being selected because the validation is looking for a vertical bar character that isn't there anymore.
The file in question is imagefield.js. I'm trying to understand the javascript regex but not getting too far with it.

FWIW This issue has "apparently" been fixed but it still seems to be the a problem with 5-x.2.1
http://drupal.org/node/280801

My clean version of imagefield 5.x-2.1 uses version imagefield.js,v 1.1.2.1 which has been fixed 4 months ago but still not released.
ARGH!!!

So the solution is to browse the CVS repository & use the versions that have the commit by dopry 'switch accept to use a , instead of |'

I think it is just the .module and the .js files you need from here…
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/imagefield/...

Can someone release this so we don't waste time fixing things that have been fixed already?

drew reece, there have been problems with getting the -dev release packaged but i for one am not going to create a 2.2 release until i get some feedback on the current 5.x-2.x-dev release. the last thing i need is even more support issues that i don't have time for. we finally got http://drupal.org/node/157163 sorted out today so download it and if it's working let me know. but as it is this has already been fixed.

Drewish,
I got it & installed on a stage site (minutes after the packaging script ran). It works in Opera on the PC - users can add images now.
One problem is that Opera throws up a dialog "JavaScript - Unspecified error" when the upload button is clicked. If I leave the script to continue it runs, and the image gets uploaded. This error also occurs on the file attach button (on file attachments etc) on nodes with no imagefields so I think it is from another script.

I reverted the module and the same "Unspecified error" also occurs with imagefield 5.x-2.1. It happens on the mac too, but so far only in Opera (latest version 9.62), not Firefox or Safari.

I'm unable to find the reason for the error, but at least now my admin can use Opera to submit images.

Setting breakpoints in Opera's error console seems to point to line line 38 of upload.js, but if I pin it down with some certainty I'll post to the appropriate issue queue.

One weird thing I noticed is that when an incorrect file type is added, the list of recommended types has a space only after the first type. The replace function on line 14 of imagefield.js is actually only replacing the first ',' in the string of allowed types. This needs to be altered…

Line 14 of imagefield.js is currently…

accept = this.accept.replace(',','|');

This needs to be more greedy :) …

accept = this.accept.replace(new RegExp(',','g'), '|');

WARNING I hacked this together and don't know ANY JavaScript (or jQuery I guess). Please check it. I simply added the 'accept' variable to the start of the error message string to be able to debug the string before it gets re-replaced on line 18.

This means that I can upload files that are not just first in the list of allowed types on my imagefield admin pages.

I hope this helps Drewish, thanks for sorting the CVS & packaging stuff, I have a hard time of making sense of the 'VC view CVS browser'.

I can add make a patch if you really want one.

Yeah I think I had to fix that in HEAD as well... I need to compare the JS on those and sync it up.

Great, I'm even more confused, HEAD has no imagefield.js file ? I must be looking at the wrong thing
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/imagefield/...

Anyway, I'd like to contribute but CVS makes little sense, but it's good that the dev snapshot is now tar'd & on the module page.

sorry should have mentioned it's moved into the filefield module: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/filefield/f...

actually, realized that i'd had to hack around filefield's crappy js in the audio module...: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/audio/audio...

i should probably get this right one place and then commit it everywhere.

That makes more sense now. I can see it makes sense to combine the similar parts since they are merging in Drupal 6. I'll test the next dev release when it changes. For now I'll trial my fixed version.

Thanks

drew, could you test out the following patch? i'd like to standardize on this if possible.

actually that last one has a bug in it.

I applied the patch via patch < path/to/file.patch and got
patching file imagefield.js
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 4 with fuzz 1.

The JS validation worked, but it doesn't check if the files added after the first one are the correct type. It waits until the file is uploaded, then highlights all the image fields with the error above them all. The offending field is also removed at that point, so it's a little unclear how to fix it (hitting submit on the node does work).

I'm hoping my patching was OK.

Subscribing

Still getting this error as well. The JS validator tells me a jpg file is not allowed, when jpg is in the accepted values list.

Edit: nevermind, I'm retarded.

Subscribing. The current -dev does not work on Firefox. Going into Firebug and removing the accept clause lets it work. I did not try fancier fixes to the accept. I need gif to work at the moment, but other places I have jpg's. It also fails on IE7 and Chrome but I can't patch it with Firebug.

Subscribing

Thanks drewish, I reviewed your changes and found only a few problems.

- Imagefield should still target it's own fields specifically: $("input.imagefield[@type='file']"), rather than all file elements.
- Imagefield errors have the class "imagefield-js-error", not "filefield-js-error".

I made these two changes then committed.