5.x-1.2 works, but infinite loops with 5.x-1.3-1

Do you have i18n installed/enabled?

same problem with d6, no i18n.

I can confirm this as well. On two different Drupal installations, one 5.9 and one 5.10, Global Redirect 5.x-1.3-1 does not work at all.

Reading this issues I tried to downgrade. First to 5.x-1.3 but it still did not work. Then I downgraded to 5.x-1.2 and that works just fine! So there's definitely something in 5.x-1.3 that breaks Global Redirect for me.

I only downgraded on the test site so far. Before I downgrade to 5.x-1.2 on the live site I would like to know if that may have any bad side effects, is there?

Could all of you please elaborate a bit further? On which paths does GR "not work"? Where do you get infinite loops? Did you try to disable (perhaps all) other contrib modules? Did you also test with a clean & fresh Drupal site?

Hi, I get this as well - on every page that is not homepage I get (in FF3) 'redirect loop - too many redirects'.

I debugged it with XDebug, and found out that browser requested rss.xml ( localhost/site/rss.xml ). The critical section is this:

conditions:

$language->prefix = "cs";
$alias = "rss.xml";
$query_string = NULL;

code:

    // Compare the request to the alias. If we have a language prefix then prefix the alias and compare. This also works as a 'deslashing' agent too
    if ((empty($language->prefix) ? $alias : $language->prefix .'/'. $alias) != $_REQUEST['q']) {
      drupal_goto($alias, $query_string, NULL, 301); //btw, why are we redirecting to $alias and not $language->prefix .'/'. $alias here??? this makes no sense to me!
    }

So, pseudocode is like this:

  if ( "cs/rss.xml" != "rss.xml" ) { 
    drupal_goto "rss.xml"; //cycles here
  }

I have no idea why is this whole if statement included - I have never used drupal to make multilingual site, but it seems to me that there should be a lot exceptions to prefixing - rss.xml is one of them, but we don't want site.com/file.jpg to be prefixed either... (?)

Anyway, I commented out this block and everything worked just like with previous version for me...

Hmm, I still have some problems - for example, after removing that if statement, I get blank page instead of redirection, for example after logging in from site.com/user...
Will return to previous version for now, but I would mark this version as dev build, definitely not as recommended...

Is -dev any better at the moment?

I see same problem with global_redirect 6.x-1.0 on a virtually fresh Drupal 6.4 install [1], i.e. I get the error 'redirect loop - too many redirects' in Firefox 3 on every existing path except the homepage (/node).

[1] My setup:

• drupal 6.4
• views-6.x-2.0-rc4
• advanced_help-6.x-1.0

Ok, I tried in a Drupal 6.4 core only install [1], and I still get 'redirect loop' on all urls except for /node.

Should I open a separate issue for the 6.x branch?

[1] That is, I disabled all my contrib modules (i.e. views and advanced help) and tried with enabling only global_redirect.

Oh, forgot to mention: my setup is a multisite Drupal install, in case that matters.

Multisite shouldn't matter... Could you test out the dev branch please?

Hi Nicholas,

I just tested globalredirect-6.x-1.x-dev and indeed, that version works just fine, for all aliased paths that I checked (I use the pathauto module). :-)

Nice one! Thanks for your great work!

BTW, I could *not* reproduce the infinite loops problem for globalredirect-5.x-1.3-1 on a drupal 5.10 (multisite) test installation.

I dont understand what was causing the infinite redirects... Glad its fixed though ;-)

Marking as fixed - any infinite look problems in 6 are fixed in dev, released to 1.1 soon. Any issues with 5.x-1.3.1 should be fixed in 1.4 soon.