Hi Greg,

nice module, i need these two features on 5.x, and going to add them myself:

Ability to disable cron mass deletion
Provide a form with options to mass delete on press of button

if you are interested to have a co-maintainer for this module, i volunteer.

Best,

Max

CommentFileSizeAuthor
#4 revision_deletion_patch_02.txt2.08 KBginc
#2 revision_deletion_patch_01.txt824 bytesginc

Comments

Gman’s picture

Gman commented

The form to manually run the mass deletion is found at /admin/content/revision_deletion. If any revisions match the criteria found in the settings, they will be listed. And there is a button to run the deletions.

If you want to make to disable the cron, patches are most welcome. Thank you. -Greg

ginc’s picture

ginc commented
StatusFileSize
new revision_deletion_patch_01.txt824 bytes

the module setting allows deletion of revisions older than 1 week, I added more 'age' options so it could delete all of them. patch attached.

i also found the way node list handled in /admin/content/revision_deletion problematic as it tries to list all node revisions that match the criteria in one page, on my test environment i had over 5000 nodes, each one with 2 or 3 revisions and my browser tried to stop the script several times before the page generated. the same problem with the deletion report. I think i will open a new issue for this.

I will submit the patch disabling the corn soon.

ajaysolutions’s picture

ajaysolutions commented

That second issue you raise is one I ran into - well, it didn't stop before the page was generated, because I only have about 25 nodes, but some over hundreds of revisions, so I could immediately see how it could be problematic.

I think it needs to page maybe default of 100 per page? Maybe even have options for how many to show, or "show all". I dunno.

Al,

ginc’s picture

ginc commented
StatusFileSize
new revision_deletion_patch_02.txt2.08 KB

here is the patch that adds ability to disable cron in setting page, it includes the first patch i submitted here. i also improved the text in settings to make it more end user friendly. e.g. node type -> content type, cron job -> automatic deletion

ginc’s picture

ginc commented
Assigned: Unassigned » ginc
Status: Active » Needs review
Gman’s picture

Gman commented
Status: Needs review » Fixed

Committed to the D5 and D6 branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

gpk’s picture

gpk commented
Status: Closed (fixed) » Active

There still seems to be no option to disable the automatic cron deletion without disabling the module ... in both 5.x and 6.x ...

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

The patch in #547650: Coding standards adds a "manual" setting to the cron interval, and makes that the default. If I get CVS access, I will commit it.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Fixed
nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Fixed » Closed (fixed)