Ability to disable cron and mass delete on press of button

GA - August 7, 2008 - 20:23
Project:Revision Deletion
Version:5.x-1.1
Component:User interface
Category:feature request
Priority:normal
Assigned:GA
Status:closed
Description

Hi Greg,

nice module, i need these two features on 5.x, and going to add them myself:

Ability to disable cron mass deletion
Provide a form with options to mass delete on press of button

if you are interested to have a co-maintainer for this module, i volunteer.

Best,

Max

#1

Gman - August 7, 2008 - 20:42

The form to manually run the mass deletion is found at /admin/content/revision_deletion. If any revisions match the criteria found in the settings, they will be listed. And there is a button to run the deletions.

If you want to make to disable the cron, patches are most welcome. Thank you. -Greg

#2

GA - August 8, 2008 - 12:27

the module setting allows deletion of revisions older than 1 week, I added more 'age' options so it could delete all of them. patch attached.

i also found the way node list handled in /admin/content/revision_deletion problematic as it tries to list all node revisions that match the criteria in one page, on my test environment i had over 5000 nodes, each one with 2 or 3 revisions and my browser tried to stop the script several times before the page generated. the same problem with the deletion report. I think i will open a new issue for this.

I will submit the patch disabling the corn soon.

AttachmentSize
revision_deletion_patch_01.txt 824 bytes

#3

ajaysolutions - August 9, 2008 - 17:17

That second issue you raise is one I ran into - well, it didn't stop before the page was generated, because I only have about 25 nodes, but some over hundreds of revisions, so I could immediately see how it could be problematic.

I think it needs to page maybe default of 100 per page? Maybe even have options for how many to show, or "show all". I dunno.

Al,

#4

GA - August 9, 2008 - 21:17

here is the patch that adds ability to disable cron in setting page, it includes the first patch i submitted here. i also improved the text in settings to make it more end user friendly. e.g. node type -> content type, cron job -> automatic deletion

AttachmentSize
revision_deletion_patch_02.txt 2.08 KB

#5

GA - August 9, 2008 - 21:22
Assigned to:Anonymous» GA
Status:active» needs review

#6

Gman - January 2, 2009 - 04:29
Status:needs review» fixed

Committed to the D5 and D6 branches.

#7

System Message - January 16, 2009 - 04:30
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#8

gpk - February 15, 2009 - 19:49
Status:closed» active

There still seems to be no option to disable the automatic cron deletion without disabling the module ... in both 5.x and 6.x ...

#9

NancyDru - August 12, 2009 - 22:15

The patch in #547650: Coding standards adds a "manual" setting to the cron interval, and makes that the default. If I get CVS access, I will commit it.

#10

NancyDru - August 17, 2009 - 03:38
Status:active» fixed

#11

NancyDru - August 23, 2009 - 19:51
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.