Instead of doing our own, error-prone and limited username/user picture handling in guestbook entries, we should implement User Display API, which allows to output users in a highly-configurable way throughout Drupal.

Code is in shape, patch follows soon.

CommentFileSizeAuthor
#3 guestbook-DRUPAL-5--2.user_display.patch4.51 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#245306: How to make username (uid) active in guestbook? has been marked as duplicate and contained an edge-case feature request to link a user to her guestbook page instead of her profile. Might be worth adding as configuration option to User Display API.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed

Attached replaced the previous and limited theme_guestbook_user_picture implementation with an integration of User Display API.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new guestbook-DRUPAL-5--2.user_display.patch4.51 KB
Thoor’s picture

Thoor commented

Thanks for the quick answer under: http://drupal.org/comment/reply/296186/967287

I´ve seen the problem in Version 5.x But I am using Version 6.4 and your guestbook version guestbook.module,v 1.3.2.5 2008/08/13

Is the patch above working to override the theme_guestbook_user_picture() function in Drupal 6 too?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

No, for D6 you can only override guestbook's user picture theme function in your theme, because User Display API is not yet ported to D6.

Thoor’s picture

Thoor commented

Do you mean styling the picture with css in the theme, or is there an other chance? Because I don´t find a guestbook's user picture theme function in my theme. I am using the Garland Theme so far ...

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.