When building views of issues, it seems like we're definitely going to need an argument handler for the project short name and/or project nid. It's not currently in project_issue.views.inc. @aclight: any reason why not? I know the underlying argument handler code will probably be different in D6, but is there some reason we wouldn't actually need an argument like this at all? I'm thinking of pages like project/issues/project_issue -- if you tack the project short name on there, it should filter to just issues from that project. I could imagine wanting similar things as a block on project pages with a summary of issue counts, etc, etc.

CommentFileSizeAuthor
#2 293043_pi_views_uri_arg.2.patch2.48 KBdww

Comments

aclight’s picture

aclight commented

I think what happened was that Views 1 can't support the same data in the argumen and in an exposed filter. In other words, if a user was at /project/issues/project_issue, the "Project" exposed filter wouldn't have "Project issue tracking" selected. Likewise, if a user selected a project via the exposed filter, the argument in the URL wouldn't change to match what was selected.

Because of these problems, I think we just decided to stop where we were at the time and commit what I'd done so far. So I don't think it would be difficult to write such a handler for Views 1, but also having an exposed filter is going to cause some problems.

Feel free to write this for D5 if you'd like, but as you suggest I believe the code for the D6 version will be quite different, so I doubt we'll gain much by having it in now unless you need to use this for another site now.

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 293043_pi_views_uri_arg.2.patch2.48 KB

Yes, I need this in D5 (and some other things that should be arguments, too), so I'm adding it. Doesn't seem like it hurts to have. If you want to review, please do. ;) Thanks.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

aclight pointed out a minor codestyle problem (s/true/TRUE). Otherwise, this is fine, so I committed to HEAD and DRUPAL-5--2.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.