Download & Extend
Comment Workflow » Issues

Check last state by weight, not sid

Posted by bwo on August 9, 2008 at 10:29am
Project:Comment Workflow
Version:5.x-1.1
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:John Money
Status:closed (fixed)

Issue Summary

I have installed the module and set everything according to help page, did some workflow state changes and the comments behave as they used to, I cannot see any change. What this module is supposed to do exactly? Thanks for help!

Login or register to post comments

Comments

#1

Posted by John Money on August 9, 2008 at 5:48pm
Status:active» closed (fixed)

Quick test case:

  • Node type has comments enabled (e.g. read/write)
  • Node type is assigned workflow with 3 states: created, Review, Approved
  • Node created, advancing workflow state to Review
  • Node state is changed to Approved
  • Comments are now closed (e.g. read only)
  • Node state is changed back to Review
  • Comments are now reopened (e.g. read/write)

Let me know if you need further help.

#2

Posted by bwo on August 14, 2008 at 10:11am
Title:How to use this module?» Check last state by weight, not sid
Category:support request» bug report
Status:closed (fixed)» active

OK, I know what's going on. You treat as "last state" the state with the highest sid, i.e. the last created state, which is not always the case. I think the module should the check highest weight, not sid.

#3

Posted by John Money on August 21, 2008 at 8:05pm
Assigned to:Anonymous» John Money
Status:active» closed (fixed)

Yes, indeed... new release forthcoming. Thanks for report! :)