forum_overview should not use drupal_set_title
beeradb - August 9, 2008 - 19:01
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | forum.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Jump to:
Description
There are two issues with the usage of drupal_set_title in the forum overview function. The first is that it's already set to "Forum" by forum_menu, the second is that it's not using the t() function.
Patch removed the drupal_set_title call from the function.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| forum_overview.patch | 626 bytes | Idle | Failed: Failed to apply patch. | View details | Re-test |
#1
Actually 3rd issue is that drupal_set_title is being called in a form builder, which is not supposed to have such side-effects.
#2
Just a note, this is present in 6.x as well. As trivial as this patch is, it should get backported if committed.
#3
The last submitted patch failed testing.