Download & Extend

forum_overview should not use drupal_set_title

Project:Drupal core
Version:6.x-dev
Component:forum.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

There are two issues with the usage of drupal_set_title in the forum overview function. The first is that it's already set to "Forum" by forum_menu, the second is that it's not using the t() function.

Patch removed the drupal_set_title call from the function.

AttachmentSizeStatusTest resultOperations
forum_overview.patch626 bytesIdleFailed: Failed to apply patch.View details

Comments

#1

Actually 3rd issue is that drupal_set_title is being called in a form builder, which is not supposed to have such side-effects.

#2

Just a note, this is present in 6.x as well. As trivial as this patch is, it should get backported if committed.

#3

Status:needs review» needs work

The last submitted patch failed testing.

#4

#5

Version:7.x-dev» 6.x-dev
Status:fixed» active

#6

Status:active» fixed

D6 is not affected

Related issue #148145: "Forums" title is not localized

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here