Drupal 5 script for _phptemplate variables doesn't work with ATCK
bcobin - August 9, 2008 - 20:36
| Project: | Advanced Theme Construction Kit (ATCK) |
| Version: | 5.x-5.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Jump to:
Description
This is odd - I just get a white screen. I've used Advanced Forum before (on www.aliceborodkin.com - hey, it's not my fault if the client hasn't used it!) - this is with the same theme (ATCK) and I'm inserting the code in exactly the same place as I did before. I've tried with an earlier version of AdvForum (alpha7) and the behavior is the same - just a white screen. So it must have to do with a change in the ATCK theme. I am stumped - any ideas?
I will include the template.php code here including where the snippet should go - and ideas would be greatly appreciated... thanks for such a cool forum! (Now if I can only get it to work...)
(If my computer is on, you can see what I'm doing at http://74.73.183.9:8888/addabbo/ )
<?php
// The vast majority of the following is directly from the Hunchbaque theme, which in turn
// borrowed several things from Zen. Isn't open-source-evolution awesome!! :-)
// (thank you very much to the authors of both of those projects)
//////////////////////////////////////////////////////////////////////////////////////////
// New regions for blocks are easy to add. Just put it in here so you have a
// new place for extra blocks. The first part is the name of the variable to
// place into your page.tpl.php and the second part is the human readable
// name that will show up in your blocks administration.
function atck_regions() {
return array(
'left' => t('left sidebar'),
'right' => t('right sidebar'),
'content_top' => t('content top'),
'content_bottom' => t('content bottom'),
'footer' => t('footer')
);
}
/**
* Quick fix for the validation error: 'ID "edit-submit" already defined' or edit-name
* There is a solution in d6 core: http://drupal.org/node/111719
*/
function phptemplate_submit($element) {
static $count_double_id=0;
$tmp = str_replace('edit-submit', 'edit-submit-'. $count_double_id++, theme('button', $element));
return str_replace('edit-name', 'edit-name-'. $count_double_id++, $tmp);
}
// Overriding existing css is often much more of a pain than just figuring out how to
// style something custom/new. Therefore we disable a lot of the core css so that we spend
// less time 'undo-ing' and more time 'doing'. The only ones left are the
// admin.css and system.css.
// The format below should be pretty easy to figure out so you can even remove
// other module's default styles if you find that they are difficult to
// override. (Or for that matter, put one back in if you like the drupal
// stuff.) I have tried to put the most crucial styles into this theme's
// style.css so that you have a good starting point though. I even included
// the .clear-block class sinc ethat is a very handy class to have.
// One other caveat to this approach is that if you want to use the non-drupal
// style method, you have to use atck_styles() in your page.tpl.php
// instead of the common $styles veriable. On the plus side, you can simply
// use the $styles variable if you don't like the approach here. Choice is good.
function atck_styles() {
$css = drupal_add_css(path_to_theme() .'/page-layout.css', 'theme', 'all');
$css = drupal_add_css();
unset($css['all']['module']['modules/node/node.css']);
unset($css['all']['module']['modules/system/defaults.css']);
unset($css['all']['module']['modules/user/user.css']);
return drupal_get_css($css);
}
// The below function is to construct a set of classes for the body tag. I
// will admit, this is pretty much taken from the Zen theme. I have added
// some minor changes to make it easier to compensate for additional regions
// that you may want to put into your template. I have documented those
// further down below.
function _phptemplate_variables($hook, $vars = array()) {
// if (module_exists('advanced_forum')) {
// $vars = advanced_forum_addvars($hook, $vars);
// }
switch ($hook) {
// Send a new variable, $logged_in, to page.tpl.php to tell us if the current user is logged in or out.
case 'page':
// get the currently logged in user
global $user;
// An anonymous user has a user id of zero.
if ($user->uid > 0) {
// The user is logged in.
$vars['logged_in'] = TRUE;
}
else {
// The user has logged out.
$vars['logged_in'] = FALSE;
}
$body_classes = array();
// classes for body element
// allows advanced theming based on context (home page, node of certain type, etc.)
$body_classes[] = ($vars['is_front']) ? 'front' : 'not-front';
$body_classes[] = ($vars['logged_in']) ? 'logged-in' : 'not-logged-in';
if ($vars['node']->type) {
$body_classes[] = 'ntype-'. atck_id_safe($vars['node']->type);
}
// This following bit of code sets flags for if sidebars exist. If you
// have multiple regions in the sidebars, add them to the conditional.
// The first is for the left side and the second for the right.
if ($vars['search_box']||$vars['block_region_1']) {
$leftBar = true;
}
if ($vars['block_region_2']) {
$rightBar = true;
}
switch (TRUE) {
case $leftBar && $rightBar :
$body_classes[] = 'sidebars';
break;
case $leftBar :
$body_classes[] = 'main-sidebar';
break;
case $rightBar :
$body_classes[] = 'secondary-sidebar';
break;
}
// implode with spaces
$vars['body_classes'] = implode(' ', $body_classes);
break;
case 'node':
// get the currently logged in user
global $user;
// set a new $is_admin variable
// this is determined by looking at the currently logged in user and
// seeing if they are in the role 'admin'
$vars['is_admin'] = in_array('admin', $user->roles);
$node_classes = array('node');
if ($vars['sticky']) {
$node_classes[] = 'sticky';
}
if (!$vars['node']->status) {
$node_classes[] = 'node-unpublished';
}
$node_classes[] = 'ntype-'. atck_id_safe($vars['node']->type);
// implode with spaces
$vars['node_classes'] = implode(' ', $node_classes);
break;
case 'comment':
// we load the node object that the current comment is attached to
$node = node_load($vars['comment']->nid);
// if the author of this comment is equal to the author of the node, we set a variable
// then in our theme we can theme this comment differently to stand out
$vars['author_comment'] = $vars['comment']->uid == $node->uid ? TRUE : FALSE;
break;
}
return $vars;
}
function atck_id_safe($string) {
if (is_numeric($string{0})) {
// if the first character is numeric, add 'n' in front
$string = 'n'. $string;
}
return strtolower(preg_replace('/[^a-zA-Z0-9-]+/', '-', $string));
}
// The next four functions sole purpose is to make a better menu. In a
// nutshell, it applies "first" and "last" classes like in the primary and
// secondary menus.
function phptemplate_menu_tree($pid = 1) {
if ($tree = phptemplate_menu_tree_improved($pid)) {
return "\n<ul class=\"menu\">\n". $tree ."</ul>\n";
}
}
function phptemplate_menu_tree_improved($pid = 1) {
$menu = menu_get_menu();
$output = '';
if (isset($menu['visible'][$pid]) && $menu['visible'][$pid]['children']) {
$num_children = count($menu['visible'][$pid]['children']);
for ($i=0; $i < $num_children; ++$i) {
$mid = $menu['visible'][$pid]['children'][$i];
$type = isset($menu['visible'][$mid]['type']) ? $menu['visible'][$mid]['type'] : NULL;
$children = isset($menu['visible'][$mid]['children']) ? $menu['visible'][$mid]['children'] : NULL;
$extraclass = $i == 0 ? 'first' : ($i == $num_children-1 ? 'last' : '');
$output .= theme('menu_item', $mid, menu_in_active_trail($mid) || ($type & MENU_EXPANDED) ? theme('menu_tree', $mid) : '', count($children) == 0, $extraclass);
}
}
return $output;
}
function phptemplate_menu_item($mid, $children = '', $leaf = TRUE, $extraclass = '') {
return ' <li class="'. ($leaf ? 'leaf' : ($children ? 'expanded' : 'collapsed')) . ($extraclass ? ' ' . $extraclass : '') . '">'. menu_item_link($mid, TRUE, $extraclass) . $children ."</li>\n";
}
// This is a bit of code so that one can easily edit the code that appears
// around all of the comments in a theme. This is not to be confused with
// what comment.tpl.php does. That is for individual comments.
function phptemplate_comment_wrapper($content, $type = null) {
static $node_type;
if (isset($type)) $node_type = $type;
if (!$content || $node_type == 'forum') {
return "<div id=\"comments\">\n ". $content . "\n</div>\n";
}
else {
return "<div id=\"comments\">\n <h2 class=\"comments\">". t('Comments') ."</h2>\n". $content ."\n</div> <!-- /#comments -->\n\n";
}
}
#1
The code looks fine to me, assuming you uncomment it. Bumping this over to your theme's queue to see if they can help.
Michelle
#2
Thanks, Michelle - much appreciated. It should be noted that Advanced Forum did indeed work with a previous version of ATCK - so the problem is most likely related to changes made since. Great module - can't wait to use it so you can see it "in the wild!"
While I'm at it, let me give kudos for the ATCK theme, too - it totally rocks.
#3
I'm not exactly sure what the deal here is, but possibly base on looking at this code in your template.php:
if (module_exists('advanced_forum')) {$vars = advanced_forum_addvars($hook, $vars);
}
...I notice that you don't define $vars as an array first. So what I'm thinking might be happening is that you're defining it as a static/single variable at first, and then the other stuff comes in behind it and just overwrites. You might want to add the following just after 'global $user' but before the module_exists statement:
$vars = array();if (module_exists('advanced_forum')) {
$vars = advanced_forum_addvars($hook, $vars);
}
#4
#5
@Caleb since $vars is being passed in as an argument, doing that would wipe out any existing values. I don't know what the problem is here, but I know that's not it.
Michelle
#6
Sorry, crossposted while the site was hiccuping.