Download & Extend

add back multiple blocks support for 6.x branch

Project:Text Link Ads Integration
Version:6.x-1.x-dev
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:pluginstla_chris
Status:closed (fixed)

Issue Summary

Doesn't seem to... if I put the comma separated list of XML codes from TLA in the box, it doesn't work. If I just put in one code, it seems to. Is this a known issue or a breakage?

Thanks!
Bruce

Comments

#1

Title:Does multi-page code work for 6.x tree?» add back multiple blocks support for 6.x branch

No, it doesn't.

I'm not sure why it was removed but I'm working to add it back...

#2

Version:6.x-2.x-dev» 6.x-1.x-dev
Status:active» needs review

Here is a patch for 6.x-1.x-dev which adds this back.

I'm not sure if it applies to the 6.x-2.x branch. I post here partially to get Mike O'Conner's feedback.

AttachmentSize
293329_tla_multiple_blocks.patch 9.53 KB

#3

Just a note that the patch seems to be working well for me... thanks so much for doing this!

Bruce

#4

I am creating a new issue since I am reporting the problem on a different release of the module. the issue for 6.x-2.x is at http://drupal.org/node/517982

But I am also mentioning here since the questions was also raised here. I will post any new info in the new issue for the 2.x version
===
The problem of not being able to have multiple keys/blocks does appear to exist in the 2.x version also.

I was upgrading from drupal 5 to 6 and was going to use version 2.x of TLA so I could have the INLINE ads support.

When I use used my original list of keys from d5 I would not get any ads back, when I deleted all but the first key, I got the ads I was expecting(for that key) Based on a log record it seems that the INLINE add function also uses that same key string since when I had added a new page it sent in a notification to the TLA site about the new content, and that included the entire key-id string as a single entry.

Since I am expecting this to not be a quick fix, I am assuming that I should go back to ver 1.x for D6 and apply the patch mentioned earlier in this thread. While this would not get me the new INLINE ads, it would continue support of the ads I am already carrying. The comments about 2.x mention database changes, so I am thinking that since I have already installed 2.x a direct replacement/downgrade to the older 1.x would not work and that a full uninstall of 2.x and a fresh re-install of 1.x would be the best approach.

Would love to see multiple blocks back in version 2.x so I could use the new INLINE ads system.

Thanks

#5

Just some follow-up.

I applied the patch to the 6.x-1.0 version of the module and it appears to be working for me. It has brought in the ads for the different keys and is displaying them in the correct blocks.

Still looking forward to an updated ver 2 with both INLINE and mult blocks.

Thanks for that patch Greggles

#6

Assigned to:Anonymous» pluginstla_chris
Status:needs review» closed (fixed)

In the current release you can add multiple XML keys to your site

nobody click here