Translatable string bugs

Posted by hass on August 10, 2008 at 1:10pm

Issue Summary

Here is a patch that fixes a few translatable string bugs in panels submodules:

Invalid marker content in panels_mini/panels_mini.module:868
* t(!empty($mini->category)?$mini->category:'Mini panel')

Invalid marker content in panels_page/panels_page.admin.inc:885
* format_plural($args_missing,t('1 argument is missing to generate a valid URL.'),t('%count arguments are missing to generate a valid URL.',
array('%count'=>$args_missing)))

Attachment	Size
panels_2x_rc1a_translatability_bugs.patch	2.46 KB

Comments

#1

Posted by sun on September 12, 2008 at 10:49pm

Status:

needs review

» needs work

This patch removes lines it should not touch. Please re-roll.

#2

Posted by hass on September 13, 2008 at 7:52am

Status:

needs work

» needs review

What you are talking about? $hidden = $panel_mini->hide_title ? ' (' . t('Title will be hidden') . ')' : ''; is NOT context sensitive (bug) and therefore integrated 3 lines below.

#3

Posted by hass on September 13, 2008 at 4:23pm

Note: I will commit new POT and German translation file that requires this patch, soon.

#4

Posted by sun on September 13, 2008 at 4:55pm

This patch needs to be committed first. You cannot speed up the process by committing a translation and translation template for not yet existing strings. Be warned.