Here is a patch that fixes a few translatable string bugs in panels submodules:

Invalid marker content in panels_mini/panels_mini.module:868
* t(!empty($mini->category)?$mini->category:'Mini panel')

Invalid marker content in panels_page/panels_page.admin.inc:885
* format_plural($args_missing,t('1 argument is missing to generate a valid URL.'),t('%count arguments are missing to generate a valid URL.',
array('%count'=>$args_missing)))
CommentFileSizeAuthor
panels_2x_rc1a_translatability_bugs.patch2.46 KBhass

Comments

sun’s picture

Status: Needs review » Needs work

This patch removes lines it should not touch. Please re-roll.

hass’s picture

Status: Needs work » Needs review

What you are talking about? $hidden = $panel_mini->hide_title ? ' (' . t('Title will be hidden') . ')' : ''; is NOT context sensitive (bug) and therefore integrated 3 lines below.

hass’s picture

Note: I will commit new POT and German translation file that requires this patch, soon.

sun’s picture

This patch needs to be committed first. You cannot speed up the process by committing a translation and translation template for not yet existing strings. Be warned.

hass’s picture

This trivial patch is already waiting for one month... please commit

merlinofchaos’s picture

hass, if you ever commit a translation again that requires a patch that is not yet in, I will ask killes and ajk to revoke your CVS access.

I am not kidding. This is not acceptable.

sdboyer’s picture

Status: Needs review » Fixed

Committed, with some modifications b/c some of the problems were already fixed in other commits.

hass’s picture

Have you also fixed this in D6? If not it needs a forward port.

hass’s picture

Status: Fixed » Patch (to be ported)
hass’s picture

Status: Patch (to be ported) » Fixed

seems to be done in a i18n patch.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.