Translatable string bugs

hass - August 10, 2008 - 13:10
Project:Panels
Version:5.x-2.0-rc1a
Component:Mini panels
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Here is a patch that fixes a few translatable string bugs in panels submodules:

Invalid marker content in panels_mini/panels_mini.module:868
* t(!empty($mini->category)?$mini->category:'Mini panel')

Invalid marker content in panels_page/panels_page.admin.inc:885
* format_plural($args_missing,t('1 argument is missing to generate a valid URL.'),t('%count arguments are missing to generate a valid URL.',
array('%count'=>$args_missing)))

AttachmentSize
panels_2x_rc1a_translatability_bugs.patch2.46 KB

#1

sun - September 12, 2008 - 22:49
Status:patch (code needs review)» patch (code needs work)

This patch removes lines it should not touch. Please re-roll.

#2

hass - September 13, 2008 - 07:52
Status:patch (code needs work)» patch (code needs review)

What you are talking about? $hidden = $panel_mini->hide_title ? ' (' . t('Title will be hidden') . ')' : ''; is NOT context sensitive (bug) and therefore integrated 3 lines below.

#3

hass - September 13, 2008 - 16:23

Note: I will commit new POT and German translation file that requires this patch, soon.

#4

sun - September 13, 2008 - 16:55

This patch needs to be committed first. You cannot speed up the process by committing a translation and translation template for not yet existing strings. Be warned.

#5

hass - September 13, 2008 - 17:16

This trivial patch is already waiting for one month... please commit

#6

merlinofchaos - September 13, 2008 - 18:12

hass, if you ever commit a translation again that requires a patch that is not yet in, I will ask killes and ajk to revoke your CVS access.

I am not kidding. This is not acceptable.

#7

sdboyer - October 5, 2008 - 23:29
Status:patch (code needs review)» fixed

Committed, with some modifications b/c some of the problems were already fixed in other commits.

#8

hass - October 6, 2008 - 08:35

Have you also fixed this in D6? If not it needs a forward port.

#9

hass - October 6, 2008 - 08:35
Status:fixed» patch (to be ported)

#10

hass - October 6, 2008 - 08:37
Status:patch (to be ported)» fixed

seems to be done in a i18n patch.

#11

Anonymous (not verified) - October 20, 2008 - 08:41
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.