Closed (fixed)
Project:
Panels
Version:
5.x-2.0-rc1a
Component:
Mini panels
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Aug 2008 at 13:10 UTC
Updated:
20 Oct 2008 at 08:41 UTC
Here is a patch that fixes a few translatable string bugs in panels submodules:
Invalid marker content in panels_mini/panels_mini.module:868
* t(!empty($mini->category)?$mini->category:'Mini panel')
Invalid marker content in panels_page/panels_page.admin.inc:885
* format_plural($args_missing,t('1 argument is missing to generate a valid URL.'),t('%count arguments are missing to generate a valid URL.',
array('%count'=>$args_missing)))
| Comment | File | Size | Author |
|---|---|---|---|
| panels_2x_rc1a_translatability_bugs.patch | 2.46 KB | hass |
Comments
Comment #1
sunThis patch removes lines it should not touch. Please re-roll.
Comment #2
hass commentedWhat you are talking about?
$hidden = $panel_mini->hide_title ? ' (' . t('Title will be hidden') . ')' : '';is NOT context sensitive (bug) and therefore integrated 3 lines below.Comment #3
hass commentedNote: I will commit new POT and German translation file that requires this patch, soon.
Comment #4
sunThis patch needs to be committed first. You cannot speed up the process by committing a translation and translation template for not yet existing strings. Be warned.
Comment #5
hass commentedThis trivial patch is already waiting for one month... please commit
Comment #6
merlinofchaos commentedhass, if you ever commit a translation again that requires a patch that is not yet in, I will ask killes and ajk to revoke your CVS access.
I am not kidding. This is not acceptable.
Comment #7
sdboyer commentedCommitted, with some modifications b/c some of the problems were already fixed in other commits.
Comment #8
hass commentedHave you also fixed this in D6? If not it needs a forward port.
Comment #9
hass commentedComment #10
hass commentedseems to be done in a i18n patch.
Comment #11
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.