Need to test creating a role, deleting a role, assigning a user to a role, renaming a role, adding permissions to a role, removing permissions from a role.

CommentFileSizeAuthor
#4 293480-user-tests-v2.patch2.92 KBjoshmiller
#3 293480-user-tests.patch2.52 KBzoo33

Comments

zoo33’s picture

zoo33 commented
Assigned: Unassigned » zoo33

We proudly accept this mission. /zoo33 & frjo

zoo33’s picture

zoo33 commented

Session is over and we finished the first part: testing role creation. Will finish the rest and submit a patch later!

zoo33’s picture

zoo33 commented
Status: Active » Needs work
StatusFileSize
new 293480-user-tests.patch2.52 KB

Here is a half-done patch. Two tests fail (I think) and we still have to do adding permissions to a role and removing permissions.

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Component: tests » other
Assigned: zoo33 » Unassigned
StatusFileSize
new 293480-user-tests-v2.patch2.92 KB

Chasing HEAD. Re-rolled patch with some fuzz. Maybe the testing bot will pick this up. Not sure what component this belongs to?

Josh

aaronbauman’s picture

aaronbauman
he/him
commented
Component: other » user.module
Status: Needs work » Needs review

Tests to a system module belong to that module. In this case user.module

if the bot still fails to pick this up, you might try renaming to user.test.patch

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I actually have really extensive role and permission tests written in #300993: User roles and permissions API. Check them out.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs work » Postponed

OK, i guess this should be postponed and pending resolution of #300993: User roles and permissions API

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

#300993 was fixed on October 8, 2009. Is there anything left to do here?
[edit: bump]

catch’s picture

catch
he/him
Primary language English
commented
Priority: Critical » Normal
Status: Postponed » Closed (duplicate)

Tests were added in that issue, so I doubt we need anything extra here.