{simpletest}.message is a VARCHAR(255), which is easy to overflow. Not a big deal in MySQL, which silently truncate fields, but important for PostgreSQL, where tests can fail because of that (one example is the forum.test with DB:TNG).

CommentFileSizeAuthor
simpletest-message-column.patch837 bytesdamien tournoud

Comments

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Patch is sane, making this text doesn't do any harm. Patch applied cleanly/worked on fresh MySQL install.

boombatower’s picture

boombatower commented

Makes sense.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks. Let's get those tests working on PostgreSQL. :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.