TestingParty08: vocabulary overview + deletion
catch - August 10, 2008 - 15:45
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | tests |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
The following needs testing:
Vocabulary overview with no vocabularies.
Changing weights on the vocabulary overview with two or more vocabularies.
Deleting a vocabulary.
When a vocabulary has a weight, check the weight is removed when other vocabularies are deleted.
#1
Fixed:
- Vocabulary overview with no vocabularies.
- Changing weights on the vocabulary overview with two or more vocabularies.
- Deleting a vocabulary.
The last one was a bug, so we didn't create test for it.
- When a vocabulary has a weight, check the weight is removed when other vocabularies are deleted.
#2
The last submitted patch failed testing.
#3
See: http://pastebin.ca/1258476
#4
The last submitted patch failed testing.
#5
Everything is green. Why did the patch fail?
#6
The patch failed due to a recent commit which completely reorganised the taxonomy test, causing your patch not to apply any longer. If the testing system says your patch needs work, it's always worth checking it applies properly on a clean copy of HEAD, and that nothing has changed which might cause the test itself to break.
I re-rolled the patch, and also fixed some comment and code style issues. The test itself looks good and we don't have test coverage for some of this stuff yet.
#7
Ok, thanks Catch. I understand now. The green fields were a little bit confusing for me... :)
#8
Spotted a couple more assertions which needed reworking.
#9
there are a bunch of really not needed calls to drupalGet() and $this->assertResponse('200'); in the last test.
#10
Missed those while cleaning up, sorry about that. Also added an additional assertion using taxonomy_get_vocabularies() to ensure that deleting everything from the UI really does work.
#11
Seems like there was various common code that should be factored out too - this substantially reduces the LOC to be maintained in the existing tests while still adding all the new tests.
#12
Very nice. taxonomy.test keeps getting smaller :)
#13
Thanks all! Committed to CVS HEAD. :-)
#14
Automatically closed -- issue fixed for two weeks with no activity.