TestingParty08: menu_rebuild_needed

Harold (MadHarold) and I wrote a simple test for this which should do the job. The test tests if the rebuild is fired by manually deleting a record from menu_router and checking if it returns after a page request.

See patch attached.

All tests pass.

Change description of final assertion, change delete query to use DBTNG.

It works and the code makes sense.

Ok, since this is a TestingParty patch, that means a merciless review since that way you learn best practices. Also, it's fun. ;)

+class MenuRebuildCase extends DrupalWebTestCase {

a) That should be MenuRebuildTestCase.
b) Please include a one-liner of PHPDoc to explain what this test case is for.

+  /**
+   * Test if the 'menu_rebuild_needed' variable triggers
+   * an menu_rebuild() call.
+   */

a) PHPDoc above functions should always attempt to fit in one line at < 80 chars. If more explanation than that is needed, make it a second sentence below.
b) Should be a menu_rebuild() not an menu_rebuild().

+    // Check if 'admin' exists

All comments should end in a period.

+    $adminexists = db_result(db_query("SELECT path from {menu_router} WHERE path='admin'"));

a) We don't smoosh together words, so this should be $admin_exists. Needs changing throughout.

+    $this->drupalGet('<front>');// menu_execute_active_handler() should trigger the rebuild.

Please move this to up above this line instead. Inline inline comments are ok for rare circumstances but are generally discouraged, especially when they're long like this.

Darn! That's all I could find. Great job! :)

Fun huh? I can't imagine what you qualify as 'unfun,' but anyway....

Fixed all your points.

Updated patch to remove the always surprising trailing whitespace.

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

Something to be thankful for, at a thankful time of year ;)

Cleans up all of modules/simpletest/tests/menu.test.

Committed to HEAD with some minor whitespace clean-up. Thanks!! :)