Undefined index: DESCRIPTION in aggregator.module on line 631.
mustafau - August 10, 2008 - 16:51
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | aggregator.module |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Description
This error appears if a feed's channel has no description element. Attached patch fixes the error.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| undefined_description.patch | 866 bytes | Idle | Failed: Failed to install HEAD. | View details | Re-test |
#1
Rerolled the patch - got "fuzz 2 (offset 9 lines)" with the original. Tested with an RSS feed w/o description to confirm the error message, patch corrects the issue. All SimpleTests for Aggregator succeed after applying the patch. +1 for RTBC.
(patch re-uploaded so it's the full path)
#2
Re-roll.
Critical because aggregator is not working without this.
#3
I understand adding the array with empty default values.
Why are you moving the $etag line to above the foreach loop? Is this needed?
#4
Mh, never mind, it does seem cleaner to put it together with the $modified line.
Testbot thinks this works, and I think the code looks good. RTBC?
#5
This needs a test.
#6
Tricky to come up with a meaningful test case there. description is a required field in RSS, so should the test case check for behavior of missing title/link as well?
#7
If 'description' is a required field, wouldn't the sensible thing to do be to reject the feed altogether?
#8
I've added a test function to UpdateFeedTestCase that may catch this, but currently even running the unmodified test case crashes with a 500 on my server, so someone else will need to work on this.
Note: This one *only* adds the test function, you still need to apply the above patch. This is to make sure the unpatched site fails the test.
#9
The last submitted patch failed testing.
#10
Works for me; the problem must be on your end, testbot.
#11
The last submitted patch failed testing.
#12
Reroll of the test.
The issue is fixed in CVS HEAD. If this test gets committed, I will submit a patch for DRUPAL-6.