Closed (fixed)
Project:
Language Icons
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
11 Aug 2008 at 09:14 UTC
Updated:
2 Sep 2008 at 17:42 UTC
Jump to comment: Most recent file
Make a languageicons.install with a languageicons_update_[1|6000]() {}, unsetting i18n_icon_* and setting languageicons_* instead.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 293758_upgrade_from_i18n-7.patch | 1.86 KB | Freso |
| #6 | languageicons.install.txt | 1.7 KB | Freso |
| #5 | languageicons.install.txt | 1.58 KB | Freso |
| #4 | languageicons.install.txt | 1.59 KB | Freso |
| #3 | languageicons.install.txt | 1.3 KB | Freso |
Comments
Comment #1
Freso commentedHere's a complete .install - including a
languageicons_uninstall()for removing the site variables when removing the module.Comment #2
Freso commentedEh. Let's try that again.
Comment #3
Freso commentedAnd here's a small update, making it call
variable_get()only once (per variable to convert) and fixing a bug due to not following up on theif (...)with{. :$Comment #4
Freso commentedAdded a bit of logic to make the update reset the
..._pathvariable if it was using the default one (drupal_get_path('module', 'i18n') .'/flags/*.png'), so that Drupal/the module will use the new location for the files. I'm not sure about this part of the update though, so feedback would be appreciated. :)Comment #5
Freso commentedAnd here's my final bid, which I have actually tested and am therefore rather confident that it works. Now I just need to know whether to drop the _path if it is
== drupal_get_path('module', 'i18n') .'/flags/*.png'or not (the current behaviour is that it does drop it (instead of converting it)).Comment #6
Freso commentedAnd here's a wee update. This one will only set
languageicons_*if they're not already set - if they are, it'll just delete the oldi18n_icon_*variable. A bit more logic about the*_pathvariable was also added.Comment #7
Freso commentedI split the
languageicons_uninstall()off into its own issue: #294819: Remove site variables in languageicons_uninstall()Also, since that one has already been committed: a re-roll, now as an actual patch!
Comment #8
jose reyero commentedLooks great to me, seems you haven't forgotten anything
Go ahead
Comment #9
Freso commentedAlright, excellent - it's been committed. :)
Comment #10
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.