I'm pleased to release for your reviews, an early version of "privatemsg-ng", a simple extension module to improve the base module with this features:

* Total integration with OG, Buddylist, Roles (Multiple select and access permission)
* File attachment
* Mailing out features (integration with job_queue (required))

TODO:

* Refactoring the theming functions
* Refactoring mailing out features

CommentFileSizeAuthor
#10 privatemsg_ng-1.patch796 bytesdavemybes
#4 privatemsg_ng-0.2.tar_.gz53.32 KBpaolomainardi
privatemsg_ng.zip11.86 KBpaolomainardi

Comments

Anonymous’s picture

Anonymous (not verified) commented
Title: Privatemsg-ng: An extension module for privatemsg » Privatemsg-ng: Buddylist 2 Support
Assigned: paolomainardi »

Hi Paolo,

thanks for this great addon. I'm using buddylist 2 instead of buddylist, so I changed (hacked) the source to make it work.

I changed "buddylist" to "buddy_api", "buddylist_get_buddies" to "buddy_api_get_buddies" throughout the source as well as the foreach loop.

<?php
foreach($buddies as $buddy_uid => $buddy_name)
  {
  $buddy_options[$buddy_uid] = $buddy_name;
  }
?>

I'm not quite sure if the foreach is the best solution, but it works nice. Now one can send messages to bl2 buddies. Maybe this is interesting for someone.

Best regards,

Mike

mrtoner’s picture

mrtoner commented
Title: Privatemsg-ng: Buddylist 2 Support » Privatemsg-ng: An extension module for privatemsg
Status: Active » Needs work

As the patch has a broader scope than integration with Buddylist 2, let's keep the original title. Setting to CNW for additional input from community.

liliplanet’s picture

liliplanet commented

subscribe

paolomainardi’s picture

paolomainardi commented
StatusFileSize
new privatemsg_ng-0.2.tar_.gz53.32 KB

New updates, code refactoring:

* Mailing out functions refactored
* Add jqueryMultiselect features to all select box
* Experimental support for buddylist2 (@hailstorm please check this for the changing)
* Added Ajax select box for OG (when you click on a OG, an Ajax select box with the OG Users will appear)

Please, review the code.

dazhdbog’s picture

dazhdbog commented

subscribing

altparty’s picture

altparty commented

Very interesting add-on! Although I have some remarks...

- The full message (incl. body) will be send to the receipients email box. I'd rather see a notification with a link to have members visiting the website.
- Within the email there's no indication where the email comes from. Maybe a editable message with tokens is a good alternative.
- I'm not sure what the actual sender-address of the email message is. Is it the website's generic email addess or is the sender-address the email address of the sending user/member? If the last option is the case, the sender's email-address will be reveiled without notice to the sender. This should be kept private.
- The Buddylist2 option doesn't work. In the 'Compose' form it shows a dropdown list with only a list of single characters, no buddies at all.

I hope these suggestions will help to enhance this add-on. Keep up the good work.

md2’s picture

md2 commented

I think truelove-nl has it spot on. I'm trying to use this module to restore PrivateMsg module's ability to send email notification to users.

Here are my 2 cents:

- I'd rather see a notification with a link back to inbox/message/login to have members visiting the website.
- For the subject, could be nice to have a text input to allow for a custom static subject (eg. "you have a new **** from *******.com"), and possible include tokens to allow for %author,%subject,%site etc.
- The moduele currently sends the email from both the site, and the users email address. In the interests of user privacy, I think a notification email from the general site email address could be best.

Great work!keep it up!

md

paolomainardi’s picture

paolomainardi commented

Thank you for the feedback, i will work on this very soon, with other nice updates.

Paolo

aharown07’s picture

aharown07 commented

Also very interested in this, thanks for your work!

davemybes’s picture

davemybes commented
StatusFileSize
new privatemsg_ng-1.patch796 bytes

Here's a patch to get the buddylist2 usernames to show up properly. Without it, the key and value are both the first letter of the buddy's username.

I also noticed that the AJAX for the OG groups doesn't seem to work properly. Nothing happens when I select an OG from Working Group or from Working Group Users. Not really sure if anything is supposed to happen there, but I suspect the Users box should show the list of actual users. And when I click the All checkbox, the Working Group Users box disappears, which is fine, but it doesn't reappear if I uncheck the All box.

Lastly, you used the wrong permission on the file attach code, so I fixed that too.

This is all done use the 5.x-3.0 version of PM and the 0.2 version of your module.

Other than that, well done on a great addition.

digidoo’s picture

digidoo commented

subscribing

kansaj’s picture

kansaj commented

Hi
I think that the module has a specific problem, related to the replies and threads replies; it does not pre-populate the To: field. The same happen when in user profile the write message is pressed. will think about some solution.
About the OG groups I do not think it is a bug , checked the code it does exactly what it should do, providing list of OGs.

paolomainardi’s picture

paolomainardi commented

A new and improved versione is arriving, new features:

* Draft messages
* Search integration with Zend Lucene (alpha quality)

And a tons of bugfixing!

Stay tuned, some cleaning on the code and i will open a project.

P.

litwol’s picture

litwol commented

Is this still for d5? i recommend to us the new and improved d6 release which features much better API.

dazhdbog’s picture

dazhdbog commented

where can we get the d6 release?

bernland’s picture

bernland commented

Do file attachments work both on the site and a member's inbox?

plan9’s picture

plan9 commented

Looking forward to the next D5 release :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Closed (won't fix)

I'm closing old issues since Privatemsg for Drupal 5 is not maintained anymore. I suggest you switch to Drupal 6 if possible, many of the reported issues are probably already resolved there and if not, you're welcome to open a new issue.