Initial conversion was performed using the deadwood project, with some manual cleanup. The entire code base needs to be audited, and functionality needs to be broken out into smaller include files where applicable.

Comments

mfm’s picture

mfm commented

To get all releated bugs to this issue,

The Ads are not displayed, when I use Javascript method (which I need, when using Caching). I concerns an Image Ad block and a HTML Ad Block. So I think that the JS does not give back a valid xhtml code.

The code that I get back when opening ...sites/all/modules/ad/serve.php?q=1&c=file&f=3&p=sites/default/files&t=11::

 document.write('\x3cdiv class=\"image-advertisement\" id=\"ad-63\"\x3e\x3ca href=\"http://www.menzer.net/de/ad/redirect/63//\" title=\"freiesMagazin ist ein monatlich erscheinendes Magazin, welches sich von einem losen Newsletter zu einem selbst\x26auml;ndigen Magazin mi\" onclick=\"window.top.location = this.href; return false;\"\x3e\x3cimg src=\"http://www.menzer.net/de/system/files/glass20-dark.png\" width=\"133\" height=\"20\" alt=\"freiesMagazin ist ein monatlich erscheinendes Magazin, welches sich von einem losen Newsletter zu einem selbst\x26auml;ndigen Magazin mi\" /\x3e\x3c/a\x3e\x3c/div\x3e');
alexandreracine’s picture

alexandreracine commented

You told me to report this here :

When clicking on publish-ad (?q=node/add/ad) you'll see the publish menu with the ad item, and with the submenus of ad, like in my case see below:

# Advertisement
* image advertisement (?q=node/add/ad/image)
* text advertisement (?q=node/add/ad/text)

Clicking on the submenus gives this error : "Fatal error: require_once() [function.require]: Failed opening required 'sites/all/modules/ad/node.pages.inc' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/drupal/montrealsalsa/includes/menu.inc on line 346"

Reference (duplicate) http://drupal.org/node/339725

sgdev’s picture

sgdev commented

I get the same error using 6.x-1.x-dev. Unable to create a new html ad node, I just receive the error mentioned in #2.

jeremy’s picture

jeremy commented
Status: Active » Fixed

A fix was committed for this today, and image ads are now working in my local testing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Babalu’s picture

Babalu commented
Status: Closed (fixed) » Active

subscribing

jeremy’s picture

jeremy commented
Status: Active » Fixed

I'm not sure why you re-opened this issue. The ad_image module was ported some time ago.

jeremy’s picture

jeremy commented

I'm not sure why you re-opened this issue. The ad_image module was ported some time ago.

Babalu’s picture

Babalu commented
Status: Fixed » Closed (fixed)

sorry, wrong issue