Hi,
i ran the module through coder and cleaned up the phone.module accordingly in this patch.

some more patch on their way to simplify code and reduce its size

CommentFileSizeAuthor
phone-consmetic-cleaning.patch19.84 KBmalaussene

Comments

malaussene’s picture

malaussene commented
Status: Needs review » Closed (fixed)

closed because the patch cannot be easily applied.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Version: master » 7.x-1.x-dev
Status: Closed (fixed) » Active

Just reactivating this issue. The patch may not be easily applied, but running this module through Coder is important.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Active » Closed (won't fix)

I'd rather not bother with this for now. Let's concentrate on the 2.x rewrite/merge of this module and cck_phone and make sure this kind of thing is taken care of during the rewrite.