Allow extra characters in the client IP regular expression

zxombie - August 13, 2008 - 23:28
Project:Shared Sign-On
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

There is a bug in the handling on client IP's to exclude from shared sign-on where it will match IP addresses the admin didn't intend to match. If the admin wishes to match, for example, 192.168.1.2, they will also match 192.168.1.20 and 192.168.1.200. This is because the form doesn't allow $ at the end of the address. Similarly 10.0.0.100 will also match 110.0.0.100 as the ^ symbol is not allowed at the start of the address.

While here I also added support for \ before .'s in the address to allow matches like ^192\.168\.1\...$ for all addresses starting with 192.168.1. followed by a 2 diget number. Without this the address 192.168.11.1 would also match.

AttachmentSize
sso-extra-chars-ip.patch1.02 KB
 
 

Drupal is a registered trademark of Dries Buytaert.