Usability: display all resource conflicts simultaneously and provide links

dww - August 14, 2008 - 00:46
Project:Resource Conflict
Version:5.x-2.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:deviantintegral
Status:closed
Description

A couple of related problems with the display of resource conflicts when creating or editing reservation nodes:

A) All of the conflicts should be reported simultaneously. I created a pair of reservations with 3 overlapping resources. When I went to submit the 2nd one, it only complained about 1 conflict. I removed that conflict, and it complained about the next one. This will definitely be a pain to use. It'd be much better if the initial error message just included all 3 conflicts.

B) It'd be nice if the reservation and resource names in the conflict error message were links to the corresponding nodes. If I'm told:

There is a resource conflict: "mixing board" is currently booked for "Recording session with Matt". Please choose a different time or a different resource.

It'd be nice to be able to just open "Recording session with Matt" in another tab and see how long that's going to go, to decide if I'm going to pick a different time.

C) Since we know all reservations have date information, we could just include that directly in the message, reducing the need to click on the conflicting reservation nodes at all. For example:

There is a resource conflict: "mixing board" is currently booked for "Recording session with Matt" from 2008-08-24 16:00 to 2008-08-24 19:00. Please choose a different time or a different resource.

This should all be pretty easy, I just don't have time to generate a patch right now since I'm out the door. Wanted to get an issue started while it's still fresh on my mind. ;)

Thanks,
-Derek

#1

deviantintegral - August 15, 2008 - 17:30
Assigned to:Anonymous» deviantintegral

#2

deviantintegral - August 15, 2008 - 18:13

A) has been fixed. form_set_error was using the same name for every error, so each one was being overwritten.

B) I agree, and done.

C) Yes, good idea.

It's all been committed in CVS #133998.

#3

deviantintegral - August 15, 2008 - 18:14
Status:active» fixed

#4

dww - August 15, 2008 - 18:59

Sweet, thanks. ;)

#5

dww - August 17, 2008 - 17:31
Status:fixed» needs review

The committed code doesn't handle the case of multiple conflicting resources from the same node. Attached patch solves it (with comment).

AttachmentSize
295075_report_all_conflicts.patch 1.17 KB

#6

dww - August 17, 2008 - 17:41
Status:needs review» fixed

After review from deviantintegral via IRC, committed this to DRUPAL-5--2.

#7

Anonymous (not verified) - August 31, 2008 - 17:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.