Choose which search implementation should be default (including search box)

@RobertDouglass & @drunkenmonkey,

Can one of you guys take a look at this? I feel it is really important to foster adoption.

Best,
Jacob

The approach is good but I think it should be part of the http://drupal.org/project/search_config module. (Actually, I think it should be part of core).

This is great! Works perfectly. Only one suggestion:

Improve the documentation inline on them form. Right now, it's a little sparse, it's a little hard to describe I suppose, but something a little more verbose might help. Really nice though!

Also, check for style things like spaces after commas, etc... It's not terribly important, but worth a scan

Looks good to me! I'm not rechecking the patch, but I assume it is fine. Any other reviewers?

It looks OK but I'll see if I can apply it later and do some actual testing.

I think #base is a deprecated property:

+  if ($form['#base'] == 'search_box_form') {

Doesn't $form_id have the information you're looking for?

Favored Drupal coding style is to use full-word variable names with underscores separating words:

+        '#options' => $imparr,

should become

$implementor_array = 

But really, that code can be rewritten:

+      $implementors = module_implements('search', false, false);
+      unset ($implementors[array_search('search_config', $implementors)]);
+      foreach($implementors as $imp) {
+        $imparr[$imp] = $imp;
+      }

becomes

+      $searches = drupal_map_assoc(module_implements('search', false, false));
+      unset ($searches['search_config']);

And finally, I'd prefer this:

+      $description = t('Which tab on the search results will be presented by default.
+      The standard Drupal installation defaults to node_search ("Content" tab). This option allows you to default to the "User" tab
+      or any other tab from contributed search modules, e.g. 
+      Apachesolr which implements a tab called "Search" to display its results');

(added t(), as opposed to t($descriptions) later in the form)

@pahariwalla: FYI: http://api.drupal.org/api/function/drupal_map_assoc/5

Did a quick test, on a mostly clean install, and things seem to work as expected. There is a possible minor usability issue though. The search block will use the assigned default search and depending on what that is the initial search results might be a little surprising as there is no way to indicate that you will be searching "users", for example, instead of "content" from the search block. This is even more evident if the default search is "user" and the person does not have access to search users. All search results return empty. I don't think it will be much of an issue in practice though.

I cleaned up the patch at a little but mostly for style fixes. I also removed the $mod variable since it wasn't needed. If someone else could test and let me know how it goes I'll gladly commit it.

Works great!

Fixed in #141753.

Thanks.

New release out with the feature added. Thanks again everyone.

Closing.