Wrong implementation of login

Another problem - when registering if profile module enabled
user_external_login_register -> user_save -> profile_save_profile -> _profile_get_fields -> user_access('administer users')

when user is registering there's no global $user variable

    * warning: array_fill() [function.array-fill]: Number of elements must be positive in D:\www\docs\rnm\includes\database.inc on line 240.
    * warning: implode() [function.implode]: Invalid arguments passed in D:\www\docs\rnm\includes\database.inc on line 240.
    * warning: array_keys() [function.array-keys]: The first argument should be an array in D:\www\docs\rnm\modules\user\user.module on line 500.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT p.perm FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN () in D:\www\docs\rnm\modules\user\user.module on line 500.

suppose this issue for core...

ups ... fixed in 6.4

Massa, trying to use explode and $name[1] brings php notice
(If delimiter contains a value that is not contained in string, then explode() will return an array containing string. )

Better replace

    $name     = explode('@', trim($form_state['values']['name']));
    $username = $name[0];
    $server   = $name[1];

    // If no server was specified, get the default option if its required
    if (empty($server) and variable_get('site_network_client_server', '')) {
      $server = variable_get('site_network_client_server', '');
    }

With

    $name     = explode('@', trim($form_state['values']['name']));
    $username = $name[0];

    // If no server was specified, get the default option if its required
    if (!isset($name[1]) and variable_get('site_network_client_server', '')) {
      $server = variable_get('site_network_client_server', '');
    }
    else {
      $server = $name[1];
    }

It's more readable and optimized :) and no notices in log