1. implements the validation of french phone number based on
    http://www.itu.int/itudoc/itu-t/number/f/fra/70680.html
  2. add hook_simpletest in phone.module
  3. add test for validation and formatting of french phone numbers
CommentFileSizeAuthor
#3 phone_update_simpletest.patch1.09 KBmalaussene
phone-fr.patch9.18 KBmalaussene

Comments

malaussene’s picture

malaussene commented

ping

thierry_gd’s picture

thierry_gd commented
Status: Needs review » Fixed

Taken into account in 6.2.8 release

malaussene’s picture

malaussene commented
StatusFileSize
new phone_update_simpletest.patch1.09 KB

Hi thierry_gd,

thanks for including it.

just to let you know my patch was for Drupal 5, the unit test does not work currently in HEAD.

In order to make it work:

  1. phone_simpletest is only needed for simpletest-5.x-1.x, so it can be can dropped for Drupal 6
  2. there are some changes between simpletest-5.x-1.x and simpletest-6.x-1.x requiring some adjustments in phone-fr.test
  3. phone-fr.test MUST be in tests folder

patch attached for 1,2

as a side note, if you are looking for a co-maintainer, I would be happy to help you ;)

malaussene

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.