If you allow for default imagecache preset names, the number of db queries can be reduced. For example, if the default preset names are 'user_thumbnail' and 'user_profile'. If a user creates presets with these names, and configures imagecache_profiles to indicate they have done so, the db queries to get the $size can be eliminated. If they use their own preset names, it functions as is.

Is this a sensible recommendation?

Comments

v1nce’s picture

v1nce commented

Please provide a patch and I'll have a look. This sounds sensible.

kulfi’s picture

kulfi commented

Oops. Am not a coder, otherwise I would have provided you with something already :(

George2’s picture

George2 commented

why not just use the imagecache preset names as values in the form? that way, the imagecach ename can be passed directly to the theme_imagecache function

v1nce’s picture

v1nce commented
Version: 5.x-1.4 » 6.x-1.0
Assigned: Unassigned » v1nce
Status: Active » Fixed

This has been updated in the 6.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.