Different date formats

Posted by FrankT on August 14, 2008 at 5:47pm

Issue Summary

I have several suggestions for improving (in my eyes) the user interface:

I'd like to have the settings as a tab instead of a submenu (it is better to handle especially with the DHMTL menu module as it by default doesn't display menu items that have sub-items). Also the settings are kind of hidden under a menu entry title 'Revision deletion'. The menu title (better a tab title!) should be renamed to 'Settings'

In the settings there is a string 'Age in days of revisions that should be deleted.' which I would change into 'Age of revisions that should be deleted.' as there are not only option in days but also in weeks.

There is also an untranslatable string 'No Node Revisions to delete at this time. ' on ?q=admin/content/revision_deletion.

Finally there is a string 'Select node types for revision deletion. Multiple select enabled.' which ends with a dot although there is a hardcoded ':' after it.

Thanks for the module anyway!

Comments

#1

Posted by NancyDru on August 12, 2009 at 10:18pm

Status:

active

» patch (to be ported)

Please check the patch in #547650: Coding standards. I believe it takes care of all your concerns, but still needs to be ported to 6.x.

#2

Posted by NancyDru on August 17, 2009 at 3:39am

Status:

patch (to be ported)

» fixed

#3

Posted by FrankT on August 21, 2009 at 2:37pm

Status:

fixed

» active

Thanks so far. After updating to the latest version there is still a menu entry under 'Revisions to Mass Delete' (/admin/content/revision_deletion), named 'Revision Deletion' which points to the settings tab (/admin/content/revision_deletion/settings).

The menu entry 'Revision Deletion can be removed, or is it a bug in my installation?

I also suggest to replace the setting 'Show conditional labels' by 'Show additional labels', so far I do not understand why the labels should be conditional.

#4

Posted by NancyDru on August 21, 2009 at 3:46pm

Status:

active

» postponed (maintainer needs more info)

This is what you should see

  $items['admin/content/revision_deletion'] = array(
    'title' => 'Revisions to Mass Delete',
    'page callback' => 'revision_deletion_settings_page',
    'access arguments' => array(REV_DEL_PERM),
    'type' => MENU_NORMAL_ITEM,
    'description' => 'Configure or manually run the revision deletion module',
    );

  $items['admin/content/revision_deletion/list'] = array(
    'title' => 'List',
    'page callback' => 'revision_deletion_page',
    'access arguments' => array(REV_DEL_PERM),
    'type' => MENU_DEFAULT_LOCAL_TASK,
    );

  $items['admin/content/revision_deletion/settings'] = array(
    'title' => 'Settings',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('revision_deletion_settings'),
    'file' => 'revision_deletion.admin.inc',
    'access arguments' => array('administer site configuration'),
    'type' => MENU_LOCAL_TASK,
    'description' => 'Configure settings for the revision deletion module',
    );

I assume you did run update.php, which is necessary with the menu changes.

I called them "conditional" because they depend on the other settings as to whether or not they are produced. But I went ahead and changed them. BTW, have you looked at translation and whether there are any fixes needed for that?

#5

Posted by FrankT on August 22, 2009 at 7:18am

Thanks, I always run update.php after any updates, but the menu system sometimes behaves strange sometimes. I think I will uninstall the module once and reinstall it again.

I will have a look at the changes this weekend (they are not yet in the dev version of Aug 22!?), I will update my translation and post it shortly then.