Look here for steps to reproduce: http://drupal.org/node/295177

Attached is a patch that will change the druplicon menu path in admin_menu to be the absolute path to the homepage. This will create a menu item that will have a path that will not conflict with pathauto's lookup. The front page in admin_menu should be the only path that conflicts with pathauto.

CommentFileSizeAuthor
#10 use-front-295476-8.patch3.27 KBpwolanin
#6 use-front-295476-6.patch2.53 KBpwolanin
am_pa_conflict.patch1.17 KBredndahead

Comments

redndahead’s picture

redndahead commented
Priority: Normal » Critical

Changing this to critical as this will break websites.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Why do we have to set absolute = TRUE ?

redndahead’s picture

redndahead commented

That will add the http://mysite.com etc. otherwise you would output the same thing as you are now giving you the same error.

redndahead’s picture

redndahead commented

Better description:

I have a menu created that points to node/1 so in the menu_links db there is a path node/1
when admin_menu is enabled it adds the frontpage to the menu into the menu_links db. So it add a path node/1 to the menu_links table.
Now their are 2 node/1 paths

Now I am using path_auto and I have set the path when I save a page to be menu-path-raw. So I go to node/1 and save that node. It will do a search for node/1 and get the menu name. When it does a search it finds the admin_menu node/1 and prints it's title which in this case is an image tag to the druplicon.

absolute => true will change the path that admin_menu saves so that it is http://mysite.com/node/1 so when token does a lookup it will not find that path.

Proct0t’s picture

Proct0t commented

Similar issue going on at #279767: User counter is output on login page for anonymous users

pwolanin’s picture

pwolanin commented
StatusFileSize
new use-front-295476-6.patch2.53 KB

in fact, can be saved as a distinct path - it will not be substituted.

I think this issue is distinct from the one where the wrong link is called - that's caused by other modules doing an incorrect query. Probably pathauto should also be more careful, but I think this patch will alleviate some problems.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Trying to get some more attention.

pwolanin’s picture

pwolanin commented

This probably needs an update function - otherwise I think the patch with give the double icon problem

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs work
pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new use-front-295476-8.patch3.27 KB

this is a little heavy-handed for the update, but should work for everyone.

bengtan’s picture

bengtan commented

Subscribing.

redndahead’s picture

redndahead commented
Status: Needs review » Reviewed & tested by the community

Tested the patch and it's working as planned. Sorry for the delay in testing. I like the wipe and rebuild feature.

pwolanin’s picture

pwolanin commented
Status: Reviewed & tested by the community » Fixed

committed and also releasing 6.x-1.1

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

@pwolanin: Thanks for keeping at this issue. However: Please look at the issue queue in front of creating a new release. If you had looked, you would have seen #305468: admin_menu 6.x-1.2. Over there is a list of issues, which are all critical, closely related, and not fixed yet. I urge you to assume more responsibility for co-maintaining this project, please. Unfortunately, this is the second release that has been published too early in terms of stability and reliability, and there is no question that end-users will blame us for doing so. I understand that release-early-release-often is a popular practice; however, admin_menu 6.x is still far away from being as stable as 5.x, and in this stage, each release should really include major bug fixes or we will sell our users. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.