Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hallo,
We had some troubles with this module because of the double appearance of the option "Allow comments to alter this field" in the settings section of the CCK fields (when changing basic information of a CCK field, the option appears again). Changing both options lead to some conflicts where the new setting was not stored and nodes including comments with CCK field changes could not be displayed anymore (Fatal error: Cannot access empty property in /sites/all/modules/comment_cck/comment_cck.module on line 158).
After some investigation I found some NULL values because of wrong (missing) array indices and corrected them. Then I introduced some new conditions in the form alter hook to get rid of the second appearance of the option in the administration section.
Here are my changes in patch form and the resulting module file itself, it works fine for me and I hope it helps others, too.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | comment_cck-remove_double_checkbox-1.patch | 1.62 KB | joshuajabbour |
| #1 | comment_cck.module.patch | 1.61 KB | klausi |
| #1 | comment_cck.module.txt | 9.19 KB | klausi |
| comment_cck.module.txt | 9.28 KB | klausi | |
| comment_cck.module.patch | 1.7 KB | klausi |
Comments
Comment #1
klausiUpdate: Changed the additional if-condition, because it was language dependent.
Comment #2
crizthx, the module is working as supposed now I think...
Comment #3
agentrickardBug confirmed. The patch removes the checkbox from the initial (basic field information) screen, which should be acceptable.
When you go from the field editing form to the 'edit basic information' form, the Comment CCK value is dropped. The patch also corrects $form_state['values'] usage instead of the old $form_values inside
_comment_cck_submit().Comment #4
arhak commentedsubscribing
Comment #5
sanduhrsBug confirmed, the attached patch works well.
Comment #6
joshuajabbour commentedHere's a new patch that doesn't conflict with #309367: Not Compatible with CCK 6.x-2.1. The patch in that issue should be applied first. I'm leaving this one as RTBC as the change is just a small change to the function name in the previous patch.
Comment #7
joshuajabbour commentedI've written a new, unified patch that fixes this issue along with a few others. It's listed under #420092: Bring comment_cck up-to-date, combine patches and can (should) be applied in place of the patch above.
Comment #8
mitchell commentedCommitted. Thanks!