error in update-nodewords.php :( [#29562]

I wanted to update the module to your new CVS version
the first error was in line 18:
variable_del('nodewords_global_keywords);
should be
variable_del('nodewords_global_keywords');

and then comes
Fatal error: Call to undefined function: module_exist() in D:\Eigene Dateien\Webserver\drupal_cvs\update-nodewords.php on line 11

please fix it soon
thanks

Comment	File	Size	Author
#2	update-nodewords.php.patch	594 bytes	Tobias Maier

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Robrecht Jacques CreditAttribution: Robrecht Jacques commented 25 August 2005 at 07:06

Assigned:

Unassigned

» Robrecht Jacques

Fixed in CVS.

Comment #2

Tobias Maier CreditAttribution: Tobias Maier commented 25 August 2005 at 11:31

File	Size
update-nodewords.php.patch	594 bytes

have you ever tried your update?
it does not work!

here comes a patch which does it for me!

please commit it and look at the manual for drupal_bootstrap()

thanks again

Comment #3

Tobias Maier CreditAttribution: Tobias Maier commented 25 August 2005 at 11:31

Status:

Active

» Needs review

Comment #4

Tobias Maier CreditAttribution: Tobias Maier commented 25 August 2005 at 11:34

why cant the update rename the old table
set up the new one
copy the datas
and delete the old table?

Comment #5

Robrecht Jacques CreditAttribution: Robrecht Jacques commented 26 August 2005 at 06:59

Status:

Needs review

» Fixed

Thanks. Probably fixed in CVS-HEAD now.

why cant the update rename the old table
set up the new one
copy the datas
and delete the old table?

Because there is no database agnostic function for that. The format in PostgreSQL and MySQL is different for creating tables. Furthermore, this doesn't seem to be common practise in Drupal.