Updated to the latest snapshot shortly after upgrading to 5.10 (was using the facebook-status snapshot from about august 7 before) and started getting these errors:

warning: in_array() [function.in-array]: Wrong datatype for second argument in /htdocs/drupal-5.10/modules/facebook_status/facebook_status.module on line 122.
warning: in_array() [function.in-array]: Wrong datatype for second argument in /htdocs/drupal-5.10/modules/facebook_status/facebook_status.module on line 540.
warning: in_array() [function.in-array]: Wrong datatype for second argument in /htdocs/drupal-5.10/modules/facebook_status/facebook_status.module on line 152.
warning: in_array() [function.in-array]: Wrong datatype for second argument in /htdocs/drupal-5.10/modules/facebook_status/facebook_status.module on line 215.
warning: in_array() [function.in-array]: Wrong datatype for second argument in /htdocs/drupal-5.10/modules/facebook_status/facebook_status.module on line 555.
warning: in_array() [function.in-array]: Wrong datatype for second argument in /htdocs/drupal-5.10/modules/facebook_status/facebook_status.module on line 555.

Comments

icecreamyou’s picture

icecreamyou commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Assigned: Unassigned » icecreamyou
Priority: Normal » Critical

Upgrading to 6.x even though it applies to both branches, and marking as critical because it keeps the module from working correctly.

I'm looking into this right now. All of these errors have to do with a line that looks similar to this:

in_array(variable_get('facebook_status_clear_user', array(0)), $fbs_uid)

So the problem is apparently that $fbs_uid is not the right type of data for the second argument in in_array().

icecreamyou’s picture

icecreamyou commented
Status: Active » Needs review

Alright, so it turns out I had the format backwards; in_array() is supposed to be in the format in_array(mixed needle, array haystack). In other words, the line given above should have been 

in_array($fbs_uid, variable_get('facebook_status_clear_user', array(0)))

That's fixed now, and about to be committed to CVS.

maytagman’s picture

maytagman commented

Awesome! Thanks for the great module and fast work!

icecreamyou’s picture

icecreamyou commented
Status: Needs review » Fixed

I assume this is fixed now, since there haven't been any reports to the contrary.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.